Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where summary data would be interpolated #6039

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix an issue where summary data would be interpolated #6039

merged 2 commits into from
Sep 18, 2023

Commits on Sep 5, 2023

  1. Order summary keys before saving

    @eivindjahren
    eivindjahren committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7a73833 View commit details
    Browse the repository at this point in the history

  2. Go back to c implementation of summary loading 

    This removes the following unwanted behaviors of the current
implementation:

* The call to _init_numpy_vector_interp changes some values, probably due to interpolation.
* Iterating over ecl_sum uses both ecl_smspec_node->key1 and ecl_smspec_node->key2 which
  will result in duplicate entries for summary keyword types that have both types.
* DATE is included in the values loaded

However, the following behavior is kept from the most recent implementation:

* All report steps are loaded, not just those in the time map.
    @eivindjahren
    eivindjahren committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    dfb432d View commit details
    Browse the repository at this point in the history