Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where summary data would be interpolated #6039

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 4, 2023

This removes the following unwanted behaviors of the current implementation:

  • The call to _init_numpy_vector_interp changes some values, probably due to interpolation.
  • Iterating over ecl_sum uses both ecl_smspec_node->key1 and ecl_smspec_node->key2 which will result in duplicate entries for summary keyword types that have both types.
  • DATE is included in the values loaded

However, the following behavior is kept from the most recent implementation:

  • All report steps are loaded, not just those in the time map.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Wait for tests in CI to pass (see "checks" below)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured new behaviour is tested (opened GUI? screenshots? tried workflows?)

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution
    guidelines
    .

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Sep 4, 2023
@eivindjahren eivindjahren force-pushed the go_back_to_old_implementation_of_read_summary branch from 94397db to 593b085 Compare September 5, 2023 08:00
@eivindjahren eivindjahren force-pushed the go_back_to_old_implementation_of_read_summary branch from 593b085 to b7fcfac Compare September 5, 2023 08:45
This removes the following unwanted behaviors of the current
implementation:

* The call to _init_numpy_vector_interp changes some values, probably due to interpolation.
* Iterating over ecl_sum uses both ecl_smspec_node->key1 and ecl_smspec_node->key2 which
  will result in duplicate entries for summary keyword types that have both types.
* DATE is included in the values loaded

However, the following behavior is kept from the most recent implementation:

* All report steps are loaded, not just those in the time map.
@eivindjahren eivindjahren force-pushed the go_back_to_old_implementation_of_read_summary branch from b7fcfac to dfb432d Compare September 5, 2023 10:11
@eivindjahren eivindjahren mentioned this pull request Sep 5, 2023
10 tasks
@eivindjahren eivindjahren merged commit 6e7d720 into equinor:main Sep 18, 2023
40 checks passed
@eivindjahren eivindjahren deleted the go_back_to_old_implementation_of_read_summary branch September 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants