Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix deadlock problems around running forward model callback in subprocess #5974

Closed
wants to merge 19 commits into from
Closed

WIP: Fix deadlock problems around running forward model callback in subprocess #5974

wants to merge 19 commits into from

Commits on Sep 1, 2023

  1. fix the subprocess thing almost

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b308431 View commit details
    Browse the repository at this point in the history

  2. Add flag to ignore filelocking in LocalStorageAccessor

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8d5e08a View commit details
    Browse the repository at this point in the history

  3. Move callback ok wrapper to callback.py. Change signature of callback… 

    …_done to match wrapper
    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    90dc653 View commit details
    Browse the repository at this point in the history

  4. fixup: updated tests

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    86a14f4 View commit details
    Browse the repository at this point in the history

  5. Increase gui integration tests timeout

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    433158d View commit details
    Browse the repository at this point in the history

  6. fix some linting

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0d48b1b View commit details
    Browse the repository at this point in the history

  7. fixup: make skipped tests work

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    40cd450 View commit details
    Browse the repository at this point in the history

  8. drop: run int tests in sequence, and increase logging

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9a80746 View commit details
    Browse the repository at this point in the history

  9. drop: increase test timeout

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    7db4788 View commit details
    Browse the repository at this point in the history

  10. wip: add logging

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b4a90e5 View commit details
    Browse the repository at this point in the history

  11. Change Lock to RLock 

    Done in case the async handlers do something non-blocking.
This could cause a deadlock where the event_loop has one task that owns the mutex and
another task that is waiting for the mutex and not releasing control back to the event loop.
    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3716318 View commit details
    Browse the repository at this point in the history

  12. go back to original integration test setup

    @valentin-krasontovitsch @JHolba
    valentin-krasontovitsch authored and JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    00de472 View commit details
    Browse the repository at this point in the history

  13. remove logging to file in forward model

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    cf2ca09 View commit details
    Browse the repository at this point in the history

  14. fixup

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    beabedc View commit details
    Browse the repository at this point in the history

  15. mock logger for testing

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    93db3f5 View commit details
    Browse the repository at this point in the history

  16. subprocesses get their own logfiles

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e76f506 View commit details
    Browse the repository at this point in the history

  17. add logging to mutex locking

    @JHolba
    JHolba committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a207128 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. fixup flake

    @JHolba
    JHolba committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    581e438 View commit details
    Browse the repository at this point in the history

  2. fixup mypy

    @JHolba
    JHolba committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    7e31e65 View commit details
    Browse the repository at this point in the history