WIP: Fix deadlock problems around running forward model callback in subprocess #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-krasontovitsch
added
the
release-notes:skip
valentin-krasontovitsch
changed the title
valentin-krasontovitsch
force-pushed
the
fix-subprocess
branch
from
c07ac87
to
350b9ca
Compare
JHolba
force-pushed
the
fix-subprocess
branch
3 times, most recently
from
ab4e910
to
ac51cf1
Compare
valentin-krasontovitsch
force-pushed
the
fix-subprocess
branch
from
ba5697e
to
0b10013
Compare
Codecov Report
@@ Coverage Diff @@
## main #5974 +/- ##
==========================================
+ Coverage 81.90% 81.93% +0.02%
==========================================
Files 352 352
Lines 21896 21926 +30
Branches 811 811
==========================================
+ Hits 17934 17964 +30
Misses 3673 3673
Partials 289 289
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valentin-krasontovitsch
force-pushed
the
fix-subprocess
branch
from
4945a87
to
99adba2
Compare
valentin-krasontovitsch
force-pushed
the
fix-subprocess
branch
3 times, most recently
from
800156c
to
e02530e
Compare
JHolba
force-pushed
the
fix-subprocess
branch
from
38856e4
to
ea7c801
Compare
…_done to match wrapper
Done in case the async handlers do something non-blocking. This could cause a deadlock where the event_loop has one task that owns the mutex and another task that is waiting for the mutex and not releasing control back to the event loop.
JHolba
force-pushed
the
fix-subprocess
branch
from
ea7c801
to
cf2ca09
Compare
|
The code has been reverted; therefore no more deadlock issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5952
Approach
we change the process of making a new process from forking to spawning. furthermore, we add a bunch of guards for not writing already existing / uptodate files during init of local storage things. we also needed to fix some issues with pickling for the process spawning.
Pre review checklist