Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full review post-trial 01 and new episodes in tutorials-early #70

Merged
merged 26 commits into from
Jun 17, 2024

Conversation

avallecam
Copy link
Member

This PR aims to collect edit suggestions for the tutorials-early repository.

This includes any specific addition to:

  • new episodes added on read, clean, validate, and aggregate data
  • add content on epidemiological background or field applications
  • add conceptual explanations of methods

All rendered content is in https://epiverse-trace.github.io/tutorials-early/

Copy link

github-actions bot commented May 4, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-70

The following changes were observed in the rendered markdown documents:

 clean-data.md                                      | 129 +++++++++++++--------
 config.yaml                                        |   2 +-
 delays-functions.md                                |  28 ++---
 delays-reuse.md                                    |  21 +++-
 describe-cases.md                                  |  40 +++++--
 ...elays-functions-rendered-unnamed-chunk-16-1.png | Bin 50192 -> 50680 bytes
 ...elays-functions-rendered-unnamed-chunk-17-1.png | Bin 52012 -> 51545 bytes
 ...elays-functions-rendered-unnamed-chunk-20-1.png | Bin 51371 -> 51418 bytes
 ...elays-functions-rendered-unnamed-chunk-21-1.png | Bin 33484 -> 32932 bytes
 ...ransmissibility-rendered-unnamed-chunk-16-1.png | Bin 31542 -> 31716 bytes
 ...ransmissibility-rendered-unnamed-chunk-17-1.png | Bin 30825 -> 29949 bytes
 ...ransmissibility-rendered-unnamed-chunk-20-1.png | Bin 84470 -> 84466 bytes
 md5sum.txt                                         |  18 +--
 quantify-transmissibility.md                       | 121 ++++++++++---------
 read-cases.md                                      |  99 +++++++++++-----
 setup.md                                           |  33 ++++--
 simple-analysis.md                                 |  83 ++++++++++---
 17 files changed, 382 insertions(+), 192 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-17 20:48:14 +0000

@avallecam avallecam changed the title full review of tutorials-early full review of tutorials-early: new episodes + post-trial 01 May 4, 2024
@avallecam avallecam changed the title full review of tutorials-early: new episodes + post-trial 01 full review post-trial 01 and new episodes in tutorials-early May 4, 2024
Copy link
Contributor

@Degoot-AM Degoot-AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avallecam, I have a few comments on this PR, please review the changes.

.github/workflows/README.md Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
episodes/clean-data.Rmd Outdated Show resolved Hide resolved
Copy link
Member Author

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Degoot-AM I finally managed to go through all the first four episodes! thank you work on them!

I prioritized code flow, that everything is running with the recent package versions. I found some edits required for cleanepi code, and one that I reported as issue.

Then I suggested to add some space between code lines within long chunks.

I added namespace reminders and some callout box of prerequisites as reminders of the dataset that we need to download before going through the episode.

For the first episode on read case data, we may open it to four subtitles to add brief details on each step. Also I suggested a figure as a first intro to databases.

Regarding the setup page, better if we focus to update the download links and the packages required for the four episodes. We had mixed and overlapping suggestions here and in the PR #64 so better if we reconciliate them after merging these most recent edits.

Are you able to approve commits in this PR? If yes, please, go ahead!

episodes/read-cases.Rmd Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
episodes/read-cases.Rmd Show resolved Hide resolved
episodes/clean-data.Rmd Show resolved Hide resolved
episodes/describe-cases.Rmd Show resolved Hide resolved
episodes/simple-analysis.Rmd Outdated Show resolved Hide resolved
episodes/simple-analysis.Rmd Outdated Show resolved Hide resolved
episodes/simple-analysis.Rmd Outdated Show resolved Hide resolved
episodes/simple-analysis.Rmd Outdated Show resolved Hide resolved
learners/setup.md Show resolved Hide resolved
episodes/read-cases.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor

@Degoot-AM Degoot-AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @avallecam for you feedback.

episodes/clean-data.Rmd Outdated Show resolved Hide resolved
episodes/clean-data.Rmd Outdated Show resolved Hide resolved
episodes/clean-data.Rmd Show resolved Hide resolved
@@ -96,7 +96,7 @@ are okay.

This update is run ~~weekly or~~ on demand.

### 03 Maintain: Update Pacakge Cache (update-cache.yaml)
### 03 Maintain: Update Package Cache (update-cache.yaml)

For lessons that have generated content, we use {renv} to ensure that the output
is stable. This is controlled by a single lockfile which documents the packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is stable. This is controlled by a single lockfile which documents the packages
is stable. This is controlled by our (workflow) [https://github.com/epiverse-trace/tutorials-early/tree/main/.github/workflows] that can generate (PRs to update) [https://github.com/epiverse-trace/research-compendium/pull/38] package versions in the (lockfile) [https://github.com/epiverse-trace/tutorials-early/blob/main/renv/profiles/lesson-requirements/renv.lock].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this file is a workflow file from the workbench infrastructure, better to propose edits in the carpentries template file

episodes/clean-data.Rmd Outdated Show resolved Hide resolved
episodes/clean-data.Rmd Outdated Show resolved Hide resolved
episodes/clean-data.Rmd Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
@avallecam
Copy link
Member Author

redirecting this PR to main now

@avallecam avallecam changed the base branch from empty to main June 17, 2024 18:54
Degoot-AM and others added 9 commits June 17, 2024 20:01
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
Co-authored-by: Abdoelnaser M Degoot <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@avallecam avallecam merged commit d81c717 into main Jun 17, 2024
4 checks passed
@avallecam avallecam deleted the review/one-month branch June 17, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants