Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of component VaToast #3615

Merged
merged 3 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/docs/page-config/ui-elements/toast/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ export default definePageConfig({
description: "You can set custom onClick event to handle the click on button."
}),

block.subtitle("Accessibility"),
block.paragraph("Toasts are intended to be small interruptions to your vistiors or users, it's wrap with an [aria-live](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions)[[target=_blank]] region, so that changes to live regions are automatically announced by screen reader without needding to move the user's focus or otherwise interrupt the user. If the conveying messages is important, you should not add the [role](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles)[[target=_blank]] attribute that can either be [alert](https://w3c.github.io/aria/#alert)[[target=_blank]] or [alertdialog](https://w3c.github.io/aria/#alertdialog)[[target=_blank]] depending on `closeable` prop, [aria-live](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions)[[target=_blank]] will be computed and set to `assertive`. if messages is not important, you should manually set the [role](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles)[[target=_blank]] attribute to [status](https://w3c.github.io/aria/#status)[[target=_blank]], and [aria-live](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions)[[target=_blank]] should be computed to `polite`."),
block.paragraph("Note that the live region needs to be present in the markup before the toast is generated or updated. If you dynamically generate both at the same time and inject them into the page, they will generally not be announced by assistive technologies."),

block.subtitle("API"),
block.api("VaToast", apiDescription, apiOptions),

Expand Down
16 changes: 15 additions & 1 deletion packages/ui/src/components/va-toast/VaToast.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<div
v-show="visible"
ref="rootElement"
:role="$props.closeable ? 'alertdialog' : 'alert'"
:role="$props.role ?? $props.closeable ? 'alertdialog' : 'alert'"
:aria-live="computedAriaLive"
aria-atomic="true"
class="va-toast"
:class="toastClasses"
:style="toastStyles"
Expand Down Expand Up @@ -46,6 +48,8 @@ import { useComponentPresetProp, useColors, useTimer, useTextColor, useTranslati

import { ToastPosition } from './types'

import { StringWithAutocomplete } from '../../utils/types/prop-type'

import VaIcon from '../va-icon/VaIcon.vue'

const VaToastRenderer = defineComponent({
Expand Down Expand Up @@ -82,6 +86,7 @@ export default defineComponent({
},
render: { type: Function },
ariaCloseLabel: { type: String, default: '$t:close' },
role: { type: String as PropType<StringWithAutocomplete<'alert' | 'alertdialog' | 'status'>>, default: undefined },
},
setup (props, { emit }) {
const rootElement = shallowRef<HTMLElement>()
Expand Down Expand Up @@ -112,6 +117,14 @@ export default defineComponent({
color: textColorComputed.value,
}))

const computedAriaLive = computed(() => {
if (props.role === 'status') {
return 'polite'
} else {
return 'assertive'
}
})

const computedMessage = computed(() => (typeof props.message === 'function') ? props.message() : props.message)

const destroyElement = () => {
Expand Down Expand Up @@ -159,6 +172,7 @@ export default defineComponent({
visible,
toastClasses,
toastStyles,
computedAriaLive,
computedMessage,
onToastClick,
onToastClose,
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/utils/types/prop-type.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { PropType } from 'vue'

/** This will accept any string, but will suggest all strings from `T`. Used for better IDE support in component props. */
type StringWithAutocomplete<T> = T | (string & Record<never, never>)
export type StringWithAutocomplete<T> = T | (string & Record<never, never>)

// Make sure to make StringType as generic to prevent type unwrapping
/**
Expand Down
Loading