Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility of component VaToast #3615

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Improve accessibility of component VaToast #3615

merged 3 commits into from
Aug 3, 2023

Conversation

xiongmao86
Copy link
Contributor

Improve accessibility of component VaToast
Fixes #3287.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@xiongmao86
Copy link
Contributor Author

xiongmao86 commented Jul 24, 2023 •
edited
Loading

Ah, should I assign to role with $attrs.role or $props.role?

@m0ksem m0ksem self-requested a review July 24, 2023 19:25
@xiongmao86
Copy link
Contributor Author

Sorry, @m0ksem, I'll wait next time.

m0ksem
m0ksem approved these changes Jul 29, 2023
View reviewed changes
packages/ui/src/components/va-toast/VaToast.vue Outdated Show resolved Hide resolved
@m0ksem
Copy link
Collaborator

m0ksem commented Jul 29, 2023

@xiongmao86, looks good, thanks!

I might miss notifications from Github, sorry. If you ever feel lack of attention, please don't be shy to trigger me in Discord!

@xiongmao86
Copy link
Contributor Author

@m0ksem, how about the commit now, did I handle the ariaLiveComputed correctly?

@asvae
Copy link
Member

asvae commented Aug 3, 2023

Thanks. Looks good!

asvae
asvae approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤟

@asvae asvae merged commit fdef6ac into epicmaxco:develop Aug 3, 2023
2 checks passed
@xiongmao86
Copy link
Contributor Author

@m0ksem , @asvae , thanks for helping me with this pr.

@xiongmao86 xiongmao86 deleted the fix/a11y-toast branch August 6, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

@asvae asvae asvae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a11y: va-toast
3 participants
@xiongmao86 @m0ksem @asvae