Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options #6330

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jan 21, 2025

How the feature works? / How did you fix the issue?

  • fixed build for esm base64 ketcher-standalone

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

- fixed build for esm base64 ketcher-standalone
@rrodionov91 rrodionov91 merged commit 13dc6d4 into master Jan 21, 2025
11 checks passed
@rrodionov91 rrodionov91 deleted the 6246-Import_indigo_with_EXPORT_ES6_&_USE_ES6_IMPORT_META_options-fix branch January 21, 2025 14:21
YatsekTest pushed a commit that referenced this pull request Jan 22, 2025
AlexeyGirin pushed a commit that referenced this pull request Jan 24, 2025
…ptides, RNA, CHEM) … (#6329)

* All inproper library tabs switching (Favorites, Peptides, RNA, CHEM) have been replaced with the proper helper functions.

* * refactor: renamed values in the Sugars enum

* refactor: improve monomer selection and favorites management, update constants usage

What was done:
- Enhanced `selectMonomer` to support selecting various monomers across different tabs, including the Favorites tab. Added `selectMonomers`.
- Added `addMonomerToFavorites`, `addMonomersToFavorites`, `removeMonomerFromFavorites`, and `removeMonomersFromFavorites` for better management of favorites. Updated usage to leverage these functions directly.
- Moved monomer test IDs to the `monomer` constants file for centralized management and easier reuse.
- Removed unused selectors to clean up the codebase.

* feat: add new base '2imen2' to Bases enum and update test selectors for consistency

---------

Co-authored-by: Svetlana Demid <[email protected]>

* #6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options (#6330)

- fixed build for esm base64 ketcher-standalone

* Imports fixes.

* Changes in index.ts and polymerBond.ts files.

---------

Co-authored-by: Svetlana Demid <[email protected]>
Co-authored-by: Svetlana Demid <[email protected]>
Co-authored-by: Roman Rodionov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options
2 participants