Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options #6311

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jan 17, 2025

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 changed the title 6246 import indigo with export es6 & use es6 import meta options #6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options Jan 17, 2025
@rrodionov91 rrodionov91 linked an issue Jan 17, 2025 that may be closed by this pull request
@rrodionov91 rrodionov91 merged commit 2861c08 into master Jan 20, 2025
11 checks passed
@rrodionov91 rrodionov91 deleted the 6246-Import_indigo_with_EXPORT_ES6_&_USE_ES6_IMPORT_META_options branch January 20, 2025 10:30
@mathiasxx94
Copy link

Hello, I think this update broke the demo project. It seems dead so probably not very problematic for most people :p webpack "web-worker" import is not supported in demo project.

Quick and dirty fix, switch from import to require standalonestructserviceprovider in App.tsx:

import { StandaloneStructServiceProvider } from 'ketcher-standalone'; -> const { StandaloneStructServiceProvider } = require('ketcher-standalone');

@rrodionov91
Copy link
Collaborator Author

Hi @mathiasxx94
Thank you for highlighting the issue.
We found the root cause.
Will be fixed soon.

@rrodionov91
Copy link
Collaborator Author

Hi @mathiasxx94
Issue was fixed in #6330
Could you please check that everything ok now?

lmhs pushed a commit that referenced this pull request Jan 29, 2025
…6311)

- added import of indigo with separate wasm using esm imports to automatically take wasm files during the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options
3 participants