Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add annatation to grafana ingress for iframe(#213) #219

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clusters/core/addons/prometheus-operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ AWS Parameter Store structure:
| kube-prometheus-stack.grafana.admin.userKey | string | `"username"` | |
| kube-prometheus-stack.grafana.envFromSecret | string | `"keycloak-client-grafana-secret"` | |
| kube-prometheus-stack.grafana.fullnameOverride | string | `"grafana"` | |
| kube-prometheus-stack.grafana.ingress.annotations."nginx.ingress.kubernetes.io/configuration-snippet" | string | `"more_set_headers X-Frame-Options: none;"` | |
| kube-prometheus-stack.grafana.ingress.enabled | bool | `true` | |
| kube-prometheus-stack.grafana.ingress.hosts[0] | string | `"grafana.example.com"` | |
| kube-prometheus-stack.grafana.ingress.pathType | string | `"ImplementationSpecific"` | |
Expand Down
6 changes: 5 additions & 1 deletion clusters/core/addons/prometheus-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ kube-prometheus-stack:

ingress:
enabled: true
annotations:
# This annotation is intended to configure NGINX so that the X-Frame-Options header does not block
# embedding of the grafana web in an iframe.
nginx.ingress.kubernetes.io/configuration-snippet: "more_set_headers X-Frame-Options: none;"
hosts:
- grafana.example.com
paths:
Expand Down Expand Up @@ -153,4 +157,4 @@ eso:
# to support component functionality. This can be done using the provided add-ons or manually:
# https://github.com/epam/edp-cluster-add-ons/tree/main/clusters/core/addons/kuberocketci-rbac
oidc:
enabled: false
enabled: false