Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add annatation to grafana ingress for iframe(#213) #219

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

alezander86
Copy link

Pull Request Template

Description

This annotation is intended to configure NGINX so that the X-Frame-Options header does not block embedding of the site in an iframe.

Fixes #(#213 )

Type of change

  • fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Deployed on develop environment

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@alezander86 alezander86 requested a review from a team as a code owner January 24, 2025 17:29
@alezander86 alezander86 self-assigned this Jan 24, 2025
@alezander86 alezander86 added the enhancement New feature or request label Jan 24, 2025
@SergK SergK merged commit 0414e16 into main Jan 27, 2025
1 check passed
@SergK SergK deleted the EPMDEDP-1460110 branch January 27, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants