Exclude org.freedesktop.Platform.ffmpeg_full.i386 extension #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidyjames
approved these changes
Feb 9, 2024
I learned today that, in addition to the
runtime/org.freedesktop.Platform.ffmpeg-full/$ARCH/23.08 extension that exists on
all architectures, on x86_64 there is also
runtime/org.freedesktop.Platform.ffmpeg_full.i386/x86_64/23.08 to
support 32-bit binaries in an otherwise 64-bit environment. This runtime
was not being explicitly excluded from our images.
I checked the image server database with the following query:
select
build_id
from
builds_manifest
where
(data -> 'flatpak' -> 'runtimes') ?| array[
'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/20.08',
'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/21.08',
'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/22.08',
'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/23.08'
]
limit 1;
(`object ?| keys` is true if the JSON value `object` contains any
element of the array `keys` as a key.
https://www.postgresql.org/docs/13/functions-json.html)
Happily, we have never accidentally shipped this extension. Exclude it
just to be safe.
wjt
force-pushed
the
ffmpeg_full-i386
branch
from
d9edd63 to
fbf34fe
Compare
wjt
added a commit
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned today that, in addition to the
runtime/org.freedesktop.Platform.ffmpeg-full/$ARCH/23.08 extension that exists on
all architectures, on x86_64 there is also
runtime/org.freedesktop.Platform.ffmpeg_full.i386/x86_64/23.08 to
support 32-bit binaries in an otherwise 64-bit environment. This runtime
was not being explicitly excluded from our images.
I checked the image server database with the following query:
(
object ?| keysis true if the JSON valueobjectcontains anyelement of the array
keysas a key.https://www.postgresql.org/docs/13/functions-json.html)
Happily, we have never accidentally shipped this extension. Exclude it
just to be safe.