Skip to content

Commit

Permalink
Exclude org.freedesktop.Platform.ffmpeg_full.i386 extension
Browse files Browse the repository at this point in the history
I learned today that, in addition to the
runtime/org.freedesktop.Platform.ffmpeg-full/$ARCH/23.08 extension that exists on
all architectures, on x86_64 there is also
runtime/org.freedesktop.Platform.ffmpeg_full.i386/x86_64/23.08 to
support 32-bit binaries in an otherwise 64-bit environment. This runtime
was not being explicitly excluded from our images.

I checked the image server database with the following query:

    select
        build_id
    from
        builds_manifest
    where
        (data -> 'flatpak' -> 'runtimes') ?| array[
            'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/20.08',
            'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/21.08',
            'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/22.08',
            'org.freedesktop.Platform.ffmpeg_full.i386/x86_64/23.08'
        ]
    limit 1;

(`object ?| keys` is true if the JSON value `object` contains any
element of the array `keys` as a key.
https://www.postgresql.org/docs/13/functions-json.html)

Happily, we have never accidentally shipped this extension. Exclude it
just to be safe.
  • Loading branch information
wjt committed Feb 10, 2024
1 parent 3b5bb9e commit fbf34fe
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions config/defaults.ini
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ exclude_add =
org.blender.Blender.Codecs
org.freedesktop.Platform.ffmpeg
org.freedesktop.Platform.ffmpeg-full
org.freedesktop.Platform.ffmpeg_full.i386
org.freedesktop.Platform.html5-codecs
org.gnome.Totem.Codecs
org.kde.kdenlive
Expand Down

0 comments on commit fbf34fe

Please sign in to comment.