-
-
Notifications
You must be signed in to change notification settings - Fork 796
Add py3.8 to the test matrix #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7b98258
Update .travis.yml
gvbgduh 9cff68f
Add `uvloop==0.14.0.dev0` to the py3.8 version
gvbgduh 18ff4af
Fix the syntax typo
gvbgduh a244b73
Downgrade uvloop to `0.12.2`
gvbgduh 8cdb443
Update .travis.yml
gvbgduh 8e5a34f
Adjust the `uvloop` version for py38
gvbgduh d3e0e08
Rearranging setting
gvbgduh f0a166d
Update .travis.yml
gvbgduh 3e7b19d
Update .travis.yml
gvbgduh cf14e86
Update .travis.yml
gvbgduh bf5c360
Update .travis.yml
gvbgduh 49244bd
Update .travis.yml
gvbgduh ae76664
Update .travis.yml
gvbgduh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we need to install cython here?
I guess ideally we'd have test cases that just
skipif
a required dependency isn't installed.Then we can just eg. omit uvloop, until they have a non-dev version that supports 3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an experimental PR to see what it gets to get it working and it doesn't look satisfying.
It definitely a good idea to have a fallback to
asyncio
with probably a warning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd be okay on this if we'd resolved #298, and if we made the uvloop install conditional on py<=3.7 for the time being.
Users can still run on 3.8, but only if they figure out that they need to use
--loop asyncio
, which isn't ideal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually we'd got a conditional install for uvloop already. Is there a way we can also add "only for 3.6 and 3.7" to setup.py, until we've got a fix from them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, we should probably just sit tight on this... MagicStack/uvloop#277 (comment)