Add py3.8 to the test matrix #453
Conversation
Adds py3.8 to the test matrix
| pip install -U Cython; | ||
| pip install -U git+https://github.com/MagicStack/uvloop.git@1eb6727437430fe0500d7f044dd6e4432abd0901; | ||
| pip install -U click h11 httptools websockets==8.* wsproto==0.13.*; | ||
| pip install -U autoflake black codecov isort pytest pytest-cov requests; |
There was a problem hiding this comment.
How come we need to install cython here?
I guess ideally we'd have test cases that just skipif a required dependency isn't installed.
Then we can just eg. omit uvloop, until they have a non-dev version that supports 3.8.
There was a problem hiding this comment.
It was an experimental PR to see what it gets to get it working and it doesn't look satisfying.
It definitely a good idea to have a fallback to asyncio with probably a warning.
There was a problem hiding this comment.
We'd be okay on this if we'd resolved #298, and if we made the uvloop install conditional on py<=3.7 for the time being.
Users can still run on 3.8, but only if they figure out that they need to use --loop asyncio, which isn't ideal.
There was a problem hiding this comment.
Oh actually we'd got a conditional install for uvloop already. Is there a way we can also add "only for 3.6 and 3.7" to setup.py, until we've got a fix from them?
There was a problem hiding this comment.
Ah okay, we should probably just sit tight on this... MagicStack/uvloop#277 (comment)
|
last time I tried uvloop 0.14.0dev0 was not released and requires Cython
0.29.13, but uvloop pinned Cython to 0.29.10
…On Mon, Oct 21, 2019 at 4:25 PM Tom Christie ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#453 (comment)>:
> @@ -29,6 +31,11 @@ install:
elif [ "$TRAVIS_PYTHON_VERSION" = "pypy3.5" ]; then
pip install -U click h11 wsproto==0.13.*;
pip install -U autoflake codecov isort pytest pytest-cov requests;
+ elif [ "$TRAVIS_PYTHON_VERSION" = "3.8" ]; then
+ pip install -U Cython;
+ pip install -U ***@***.***;
+ pip install -U click h11 httptools websockets==8.* wsproto==0.13.*;
+ pip install -U autoflake black codecov isort pytest pytest-cov requests;
How come we need to install cython here?
I guess ideally we'd have test cases that just skipif a required
dependency isn't installed.
Then we can just eg. omit uvloop, until they have a non-dev version that
supports 3.8.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#453?email_source=notifications&email_token=AAINSPSTIVA2TDCDCFARMKTQPW3ULA5CNFSM4JCQAZD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIT5UVQ#pullrequestreview-304601686>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAINSPVWQRVWJ4LY5UPJ6UTQPW3ULANCNFSM4JCQAZDQ>
.
--
benoit barthelet
http://pgp.mit.edu/pks/lookup?op=get&search=0xF150E01A72F6D2EE
|
Adds py3.8 to the test matrix