-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DPS310 to Matek boards F722,F722-SE,F722-HD and F722-PX #578
Add DPS310 to Matek boards F722,F722-SE,F722-HD and F722-PX #578
Conversation
@@ -40,6 +40,7 @@ | |||
#include "drivers/barometer/barometer_fake.h" | |||
#include "drivers/barometer/barometer_ms5611.h" | |||
#include "drivers/barometer/barometer_lps.h" | |||
#include "drivers/barometer/barometer_dps310.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the extension is included but returning an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add some code to the makefile to ensure that the barometer_dps310.c file is being compiled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the compilation format of EmuFlight, BetaFlight and iNav is still pretty confusing to me
make/source.mk
Outdated
@@ -252,6 +252,7 @@ SIZE_OPTIMISED_SRC := $(SIZE_OPTIMISED_SRC) \ | |||
drivers/barometer/barometer_bmp280.c \ | |||
drivers/barometer/barometer_fake.c \ | |||
drivers/barometer/barometer_ms5611.c \ | |||
drivers/barometer/barometer_dps310.h \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to barometer_dps310.c instead of .h
src/main/target/MATEKF722/target.mk
Outdated
@@ -8,6 +8,7 @@ TARGET_SRC = \ | |||
drivers/barometer/barometer_bmp085.c \ | |||
drivers/barometer/barometer_bmp280.c \ | |||
drivers/barometer/barometer_ms5611.c \ | |||
drivers/barometer/barometer_dps310.h \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to a .c instead of a .h file.
this needs some testing to verify |
yes, i don't have any card with this barometer. i also couldn't compile to generate the .hex file for @goodnerdboy test and give feedback if it worked or not |
https://github.com/emuflight/EmuFlight/blob/master/docs/development/Building%20in%20Windows.md it was very confusing for me because it was old. I was unable to compile with cygwin, it returns errors |
if you give me a .hex i'll be happy to test it |
|
Thank you so much for this |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi. Tried the MATEK F722 SE target on a F722 SE with a DPS310 with no luck. |
in the issue you said you were using the matek f722, but you didn't say it was the SE version, so I didn't put the support on it. I'm going to add PR for the SE version. |
@JulioCesarMatias , can you add to this branch/PR? normally i like "atomic" PR's but in this case, i would be good to "fix both" at once. |
yes, I will add here in this branch |
MATEK_DPS310_testing_be7b986a3.zip Should new and separate target/target-names be created just for the DPS310 versions? |
I don't think it's necessary |
The board now doesn't boot normally after flashing and there is no way to connect to it through the COM |
@goodnerdboy , hold the boot-button while plugging in the USB. this will activate DFU mode for re-flashing your preferred .hex |
i know but thanks :) |
@goodnerdboy |
Yes, it is the one "bricking" the board. Once flashed the board will not reboot correctly and there is no way to connect to it (but dfu) |
@goodnerdboy I thought it was the other function, so I was wrong. I had substituted the function |
@goodnerdboy tested? |
no testing, no progress? |
without tests, I tried some friends here in Brazil with F722, but they all use the BMP280. |
I have an iFlight F7 Beast, with the DPS310 baro, I'd do some testing for you if I can. |
@JulioCesarMatias cc:@RatDad1994 , IFlight F7 Beast (IFRC_IFLIGHT_F745_AIO) is in this pull-request if you like to get the target files: The full PR 509 is not up to standard for merge, by the way, such is why it sits un-merged. |
I spent all afternoon trying to get the DPS310 to work on Emu, and I couldn't. I used a Matek F405-SE for testing. I don't know why Emu can't recognize the DPS310, I will close this PR. |
any further thoughts on this? |
i have FC with dps310 available for testing, but unable to get baro detetected in configurator. :( |
nope, it would not re-open. |
#551