Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPS310 to Matek boards F722,F722-SE,F722-HD and F722-PX #578

Closed
wants to merge 33 commits into from
Closed

Add DPS310 to Matek boards F722,F722-SE,F722-HD and F722-PX #578

wants to merge 33 commits into from

Conversation

JulioCesarMatias
Copy link
Contributor

@JulioCesarMatias JulioCesarMatias commented May 22, 2021

@@ -40,6 +40,7 @@
#include "drivers/barometer/barometer_fake.h"
#include "drivers/barometer/barometer_ms5611.h"
#include "drivers/barometer/barometer_lps.h"
#include "drivers/barometer/barometer_dps310.h"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the extension is included but returning an error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add some code to the makefile to ensure that the barometer_dps310.c file is being compiled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the compilation format of EmuFlight, BetaFlight and iNav is still pretty confusing to me

make/source.mk Outdated
@@ -252,6 +252,7 @@ SIZE_OPTIMISED_SRC := $(SIZE_OPTIMISED_SRC) \
drivers/barometer/barometer_bmp280.c \
drivers/barometer/barometer_fake.c \
drivers/barometer/barometer_ms5611.c \
drivers/barometer/barometer_dps310.h \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to barometer_dps310.c instead of .h

@@ -8,6 +8,7 @@ TARGET_SRC = \
drivers/barometer/barometer_bmp085.c \
drivers/barometer/barometer_bmp280.c \
drivers/barometer/barometer_ms5611.c \
drivers/barometer/barometer_dps310.h \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to a .c instead of a .h file.

@Quick-Flash
Copy link
Member

this needs some testing to verify

@JulioCesarMatias
Copy link
Contributor Author

this needs some testing to verify

yes, i don't have any card with this barometer. i also couldn't compile to generate the .hex file for @goodnerdboy test and give feedback if it worked or not

@JulioCesarMatias
Copy link
Contributor Author

@Quick-Flash

https://github.com/emuflight/EmuFlight/blob/master/docs/development/Building%20in%20Windows.md

it was very confusing for me because it was old. I was unable to compile with cygwin, it returns errors

@goodnerdboy
Copy link

if you give me a .hex i'll be happy to test it

@nerdCopter
Copy link
Member

if you give me a .hex i'll be happy to test it
EmuFlight_0.3.5_DP310-test.zip

@JulioCesarMatias
Copy link
Contributor Author

if you give me a .hex i'll be happy to test it
EmuFlight_0.3.5_DP310-test.zip

Thank you so much for this

@nerdCopter

This comment has been minimized.

@JulioCesarMatias

This comment has been minimized.

@goodnerdboy
Copy link

if you give me a .hex i'll be happy to test it
EmuFlight_0.3.5_DP310-test.zip

Hi. Tried the MATEK F722 SE target on a F722 SE with a DPS310 with no luck.
The baro is not recognised in auto, and setting it DPS310 in CLI has no other effet than having the baro_hardware set.
status
tasks

@JulioCesarMatias
Copy link
Contributor Author

Hi. Tried the MATEK F722 SE target on a F722 SE with a DPS310 with no luck.
The baro is not recognised in auto, and setting it DPS310 in CLI has no other effet than having the baro_hardware set.

in the issue you said you were using the matek f722, but you didn't say it was the SE version, so I didn't put the support on it. I'm going to add PR for the SE version.

@nerdCopter
Copy link
Member

@JulioCesarMatias , can you add to this branch/PR? normally i like "atomic" PR's but in this case, i would be good to "fix both" at once.

@JulioCesarMatias
Copy link
Contributor Author

@JulioCesarMatias , can you add to this branch/PR? normally i like "atomic" PR's but in this case, i would be good to "fix both" at once.

yes, I will add here in this branch

@JulioCesarMatias JulioCesarMatias changed the title Add DPS310 to Matek boards F722 and F722-SE Add DPS310 to Matek boards F722,F722-SE,F722-HD and F722-PX May 27, 2021
@nerdCopter
Copy link
Member

nerdCopter commented May 28, 2021

MATEK_DPS310_testing_be7b986a3.zip

Should new and separate target/target-names be created just for the DPS310 versions?
e.g. MATEKF722SE_DPS310 ??

@JulioCesarMatias
Copy link
Contributor Author

MATEK_DPS310_testing_be7b986a3.zip

Should new and separate target/target-names be created just for the DPS310 versions?
e.g. MATEKF722SE_DPS310 ??

I don't think it's necessary

@goodnerdboy
Copy link

The board now doesn't boot normally after flashing and there is no way to connect to it through the COM

@nerdCopter
Copy link
Member

@goodnerdboy , hold the boot-button while plugging in the USB. this will activate DFU mode for re-flashing your preferred .hex

@goodnerdboy
Copy link

@goodnerdboy , hold the boot-button while plugging in the USB. this will activate DFU mode for re-flashing your preferred .hex

i know but thanks :)
I was just describing the effect of flashing this last .hex

@JulioCesarMatias
Copy link
Contributor Author

MATEK_DPS310_testing_be7b986a3.zip

Devem ser criados nomes de destino / destino novos e separados apenas para as versões DPS310?
por exemplo MATEKF722SE_DPS310??

@goodnerdboy
did you try that?

@goodnerdboy
Copy link

MATEK_DPS310_testing_be7b986a3.zip
Devem ser criados nomes de destino / destino novos e separados apenas para as versões DPS310?
por exemplo MATEKF722SE_DPS310??

@goodnerdboy
did you try that?

Yes, it is the one "bricking" the board. Once flashed the board will not reboot correctly and there is no way to connect to it (but dfu)

@JulioCesarMatias
Copy link
Contributor Author

JulioCesarMatias commented May 29, 2021

@goodnerdboy I thought it was the other function, so I was wrong. I had substituted the function static bool deviceConfigure (busDevice_t * busDev) for the same one as INAV, when it was equal to BetaFlight it did not cause a reboot.
I am going to put the BetaFlight function back on.

@nerdCopter
Copy link
Member

@JulioCesarMatias
Copy link
Contributor Author

@goodnerdboy tested?

@nerdCopter
Copy link
Member

no testing, no progress?

@JulioCesarMatias
Copy link
Contributor Author

no testing, no progress?

without tests, I tried some friends here in Brazil with F722, but they all use the BMP280.

@RatDad1994
Copy link

no testing, no progress?

without tests, I tried some friends here in Brazil with F722, but they all use the BMP280.

I have an iFlight F7 Beast, with the DPS310 baro, I'd do some testing for you if I can.

@nerdCopter
Copy link
Member

nerdCopter commented Jul 12, 2021

@JulioCesarMatias cc:@RatDad1994 , IFlight F7 Beast (IFRC_IFLIGHT_F745_AIO) is in this pull-request if you like to get the target files:
#509

The full PR 509 is not up to standard for merge, by the way, such is why it sits un-merged.

@JulioCesarMatias
Copy link
Contributor Author

I spent all afternoon trying to get the DPS310 to work on Emu, and I couldn't. I used a Matek F405-SE for testing. I don't know why Emu can't recognize the DPS310, I will close this PR.

@JulioCesarMatias JulioCesarMatias deleted the DPS310BaroSupport branch September 19, 2021 20:43
@nerdCopter
Copy link
Member

any further thoughts on this?

@nerdCopter
Copy link
Member

i have FC with dps310 available for testing, but unable to get baro detetected in configurator. :(

@nerdCopter
Copy link
Member

nerdCopter commented Jan 9, 2024

re-opening just to attempt merge-master.

nope, it would not re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants