Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target iflight f745 aio #668

Closed
wants to merge 2 commits into from

Conversation

Kaiowarez
Copy link
Member

@Kaiowarez Kaiowarez commented Aug 8, 2021

Thank you for contributing to EmuFlight!

Copy link
Contributor

@frizzle101101 frizzle101101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure but dont think the betaflightf4 change is to be included...

@nerdCopter
Copy link
Member

can't accept this with Betaflight target modded in same branch

Copy link
Contributor

@frizzle101101 frizzle101101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you are missing #define USE_LED_STRIP, if that is realted to @Mcrubens comment on #479

@frizzle101101
Copy link
Contributor

frizzle101101 commented Aug 9, 2021

i think you are missing #define USE_LED_STRIP, if that is realted to @Mcrubens comment on #479

i realize the led pin was not broken out on the v1 but on the v1.2 it is, so please add somthing like: (this is from the inav target im working on, ur pin def may differ)
#define USE_LED_STRIP #define WS2811_PIN PD12

also id sugest removing/disabling/comenting out, the unused/not-broken-out uarts like UART_8, UART_6, UART_5, only 1,2,3,4 and 7 are broken out

@frizzle101101
Copy link
Contributor

I hope this helps with your next target adds, i sure learned somthing about Legacy targets lol

@nerdCopter
Copy link
Member

Thank you @frizzle101101 !

@Kaiowarez , there is multiple comments(info) that needs attention above, thank you good sir!

Copy link
Contributor

@frizzle101101 frizzle101101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go these are clear instructions to get this done asap by anyone who can read


#define USE_BARO
#define USE_BARO_MS5611
#define USE_BARO_BMP280
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add
#define USE_BARO_DPS310

ps if u guys need the driver (which it seems like you doo) inav and bf have it, so to prevent build failure do not remove the previous baro defines just add the new one for future driver.

#define USE_SPI_DEVICE_1
#define USE_SPI_DEVICE_2
#define USE_SPI_DEVICE_3
#define USE_SPI_DEVICE_4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer: 1 is for gyro, 2 is none, 3 is flash,4 is max osd chip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the use spi 2 define it is messing with uart 1 i believe

DEF_TIM(TIM8, CH1, PC6, TIM_USE_ANY, 0, 0 ), // S1_OUT 4 DMA1_ST1 DMA1_ST3
DEF_TIM(TIM8, CH2, PC7, TIM_USE_ANY, 0, 0 ), // S1_OUT 4 DMA1_ST1 DMA1_ST3
DEF_TIM(TIM2, CH4, PA3, TIM_USE_ANY, 0, 0 ), // S1_OUT 4 DMA1_ST1 DMA1_ST3
DEF_TIM(TIM9, CH1, PA2, TIM_USE_ANY, 0, 0 ), // S1_OUT 4 DMA1_ST1 DMA1_ST3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im preety all of these extar use any timer definition are first causing issues with uart 1,2,3,4 and are probably causing more issues, im preety sure its only motors, servos, pwm, ppm, and led strip and maybe beeper that need these definitions you can look in timer.h for more info

#define TARGET_IO_PORTD 0xffff
#define TARGET_IO_PORTE 0xffff

#define USED_TIMERS ( TIM_N(1) | TIM_N(2) | TIM_N(3) | TIM_N(4) | TIM_N(8) | TIM_N(9) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe timer 5 is missing ... uart 2 and 4 use this timer

#define USE_SOFTSERIAL1
#define USE_SOFTSERIAL2

#define SERIAL_PORT_COUNT 11 //VCP, USART1, USART2, USART3, UART4, UART5, USART6, USART7, USART8, SOFTSERIAL x 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once u remove the unnecessary uarts this shkd be 6

Comment on lines +113 to +115
#define SPI2_SCK_PIN PB13
#define SPI2_MISO_PIN PB14
#define SPI2_MOSI_PIN PB15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used remove


#define USE_SPI
#define USE_SPI_DEVICE_1
#define USE_SPI_DEVICE_2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove spi2

#define FLASH_SPI_INSTANCE SPI3

#define USE_I2C
#define USE_I2C_DEVICE_1 // External I2C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the external i2c comment

Comment on lines -121 to +123
#define USE_I2C_DEVICE_2
#define I2C2_SCL NONE // PB10, UART3_TX
#define I2C2_SDA NONE // PB11, UART3_RX
#define I2C_DEVICE (I2CDEV_2)
#define USE_I2C_DEVICE_1
#define I2C1_SCL NONE // PB10, UART3_TX
#define I2C1_SDA NONE // PB11, UART3_RX
#define I2C_DEVICE (I2CDEV_1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes

@@ -74,7 +74,6 @@
#define USE_USB_DETECT
#define USB_DETECT_PIN PC5


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes

@nerdCopter
Copy link
Member

@nerdCopter
Copy link
Member

Superseded by #686

@nerdCopter nerdCopter closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants