Skip to content

Enable browser test stdio logging by default. NFC #24180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable browser test stdio logging by default. NFC #24180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/browser/test_small_js_flags.js.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3936
4106
4 changes: 2 additions & 2 deletions test/browser_reporting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Set this to true to have stdout and stderr sent back to the server
var captureStdoutStderr = false;
var captureStdoutStderr = true;

var hasModule = typeof Module === 'object' && Module;

var reportingURL = 'http://localhost:8888/';
var reportingURL = 'http://localhost:8888';

async function reportResultToServer(result) {
if (reportResultToServer.reported) {
Expand Down
4 changes: 3 additions & 1 deletion test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2127,7 +2127,9 @@ def do_POST(self):
self.send_response(200)
self.end_headers()
else:
print(f'do_POST: unexpected POST: {urlinfo.query}')
print(f'do_POST: unexpected POST: {self.path} {urlinfo}')
self.send_response(404)
self.end_headers()

def do_GET(self):
info = urlparse(self.path)
Expand Down
2 changes: 1 addition & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ def phase_linker_setup(options, linker_args): # noqa: C901, PLR0912, PLR0915
def limit_incoming_module_api():
if options.oformat == OFormat.HTML and options.shell_path == DEFAULT_SHELL_HTML:
# Out default shell.html file has minimal set of INCOMING_MODULE_JS_API elements that it expects
default_setting('INCOMING_MODULE_JS_API', 'canvas,monitorRunDependencies,onAbort,onExit,print,setStatus'.split(','))
default_setting('INCOMING_MODULE_JS_API', 'canvas,monitorRunDependencies,onAbort,onExit,print,printErr,setStatus'.split(','))
else:
default_setting('INCOMING_MODULE_JS_API', [])

Expand Down