Enable browser test stdio logging by default. NFC #24180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_logging_by_default
branch
2 times, most recently
from
8c26ecc to
84cb611
Compare
|
Assuming this works do we think its good idea? I wonder how much it would slow down tests with a lof stdio? Since browser tests are already run iserially it think it should actually make tests failures much more easy to debug. If we choose not to do this I guess we could instead have a mechanism for enabling this on a per-test (or per-test-run) basis? |
sbc100
changed the title
kripken
approved these changes
Apr 24, 2025
|
Looks like we raced to comment :) |
|
Heh, yeah, great minds and all that... The debuggability is really nice, so if you can't measure a regression here, it's probably worthwhile? |
sbc100
force-pushed
the
browser_logging_by_default
branch
2 times, most recently
from
c10a14c to
bd2f849
Compare
sbc100
force-pushed
the
browser_logging_by_default
branch
from
bd2f849 to
8c30be5
Compare
|
It seems like at some point browser tests start failing due to lack a GL context.. its almost like the browser stops supported GL for all following tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.