Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make history dates locale rely on uiLang #1638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janekkkk
Copy link

Make history dates locale rely on uiLang

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Some commits ago, the uiLang parameter was added to the SnippetConfig.

This was made because now, the requests to the APIs rely in lang parameter, and if exist the lang shown by the UI components rely in the new uiLang parameter, so the components can have different locale for requests and UI using both parameters.

Motivation and context

Make the first character of the date always uppercase to show

Miércoles, 19 de octubre de 2022

instead of

miércoles, 19 de octubre de 2022

In English the first is uppercase, but just because names of days and months are uppercase in English and toLocaleDateString is setting that in the right way. But in Spanish, or other languages, even if the name of the day is correctly written in lowercase, we would like to start the sentence in uppercase.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@diegopf
Copy link
Contributor

diegopf commented Oct 17, 2024

@janekkkk Thank you for your contribution! Could you please add a test case for this new scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants