Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: My History dates locale should rely on uiLang #791

Open
1 task done
herrardo opened this issue Oct 19, 2022 · 10 comments
Open
1 task done

[FEATURE]: My History dates locale should rely on uiLang #791

herrardo opened this issue Oct 19, 2022 · 10 comments
Assignees
Labels
begginer Good issues for begginers enhancement New feature or request good first issue Good for newcomers help wanted Good for contributors

Comments

@herrardo
Copy link
Contributor

herrardo commented Oct 19, 2022

How can the project be improved?

Some commits ago, the uiLang parameter was added to the SnippetConfig.

This was made because now, the requests to the APIs rely in lang parameter, and if exist the lang shown by the UI components rely in the new uiLang parameter, so the components can have different locale for requests and UI using both parameters.

How can this be solved?

Change the MyHistory component to show dates based in uiLang instead of lang as locale.

Proposed solution

No response

Customizations supported

No response

Additional information

Make the first character of the date always uppercase to show

Miércoles, 19 de octubre de 2022

instead of

miércoles, 19 de octubre de 2022

In English the first is uppercase, but just because names of days and months are uppercase in English and toLocaleDateString is setting that in the right way. But in Spanish, or other languages, even if the name of the day is correctly written in lowercase, we would like to start the sentence in uppercase.

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@herrardo herrardo added enhancement New feature or request good first issue Good for newcomers begginer Good issues for begginers help wanted Good for contributors labels Oct 19, 2022
@Dhananjay-12
Copy link

Hi, I want to work on this issue. I'm new to open source

@herrardo
Copy link
Contributor Author

herrardo commented Dec 6, 2022

Hello @Dhananjay-12 I am assigning this issue to you. Sorry about not answering sooner!

@herrardo
Copy link
Contributor Author

herrardo commented Feb 7, 2023

Hello @Dhananjay-12, I am unassigning you as it seems you couldn't start the PR.

Thanks!

@Tanmay3132
Copy link

Is this issue still open ?
Can i work on it

@herrardo
Copy link
Contributor Author

Yes @Tanmay3132 , go for it ;)

@vbsh123
Copy link

vbsh123 commented Jun 25, 2023

Hey, can I work on this?

@mavmaf
Copy link
Contributor

mavmaf commented Jul 3, 2023

All yours, @vbsh123 :)

@janekkkk
Copy link

@herrardo, this issue still seems to be open. I'd like to contribute!

@herrardo
Copy link
Contributor Author

Please go ahead!

@janekkkk
Copy link

Made a PR: #1638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
begginer Good issues for begginers enhancement New feature or request good first issue Good for newcomers help wanted Good for contributors
Projects
None yet
Development

No branches or pull requests

6 participants