#1: Fix Emoticon Conversion Logic #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This pull request addresses the following changes:
Fix Emoticon Conversion Logic:
Emoticon to emoji conversion now respects boundaries (preceding and following non-space characters).
Introduced a regular expression to ensure emoticons are only replaced when surrounded by spaces or string boundaries.
Refactored #getNumberOfEmoticons and #replaceAllWithEmoji to use the new regex for accurate matching and replacement.
Remove .idea Folder:
Removed the accidentally committed .idea folder from the repository.
Added .idea/ to the .gitignore file to prevent future accidental commits of IDEA IDE configuration files.
Fixes:
Resolves issue #1 related to incorrect conversion of inline emoticons.
Additional Changes:
Updated .gitignore file to ignore the .idea/ folder.