Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Emacs 29.x compatibility #157

Closed
wants to merge 3 commits into from
Closed

[feature] Emacs 29.x compatibility #157

wants to merge 3 commits into from

Conversation

domq
Copy link

@domq domq commented Jan 5, 2023

A stab at #144.

@domq
Copy link
Author

domq commented Jan 5, 2023

Credits to @ymarco for the symlink approach and code.

Pros : doesn't require changing the release tarball structure (yet); tree-sitter-langs-compile-friendly

Cons: doesn't work very well (or at all) on Windows.

@domq
Copy link
Author

domq commented Jan 5, 2023

Fixed by making plain old copies on Windows.

@domq
Copy link
Author

domq commented Jan 16, 2023

Please consider for merging, or suggest improvements?

@meain
Copy link
Member

meain commented Jan 17, 2023

The code looks good from a quick review, but I wanna let @ubolonton decide how we wanna proceed with supporting treesit in emacs 29.

@meain meain mentioned this pull request Jan 21, 2023
@SKyletoft
Copy link

Has there been any discussion or progress on this?

Looks like Emacs 29.1 is approaching release now

@l2dy
Copy link

l2dy commented Feb 7, 2024

Any interest in getting this merged? Emacs 29.1 was released last year.

@garyo
Copy link

garyo commented Aug 18, 2024

This looked like a good change -- I wonder why it was closed? Would love to have this great set of language grammars available for built-in emacs treesit.

@zzantares
Copy link

@domq why close this?

@domq
Copy link
Author

domq commented Aug 29, 2024

@domq why close this?

Let's face it: tree-sitter is a dead project. These days one should use the merged version of it, now called treesit inside the Emacs source tree.

@jimeh
Copy link
Contributor

jimeh commented Aug 30, 2024

@domq That's kinda sad to hear. While I think/hope that the built-in treesit is the future, tree-sitter will still have value for some time if you ask me.

Most of the treesit based *-ts-mode major modes just don't seem to work as well as the original major modes for languages yet. So for most languages I still use the original major-modes with tree-sitter for improved syntax highlighting.

@meain
Copy link
Member

meain commented Aug 30, 2024

The builtin treesit modes do not yet have feature parity with major modes and there is some functionality available in emacs-tree-sitter not yet available in builtin treesit. That said, it is IMO not a good idea to have two parallel tree-sitter implementations with different user-facing APIs. This will make things harder for downstream plugins that use "tree-sitter". Hopefully the builtin modes get better soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants