-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Emacs 29.x compatibility #157
[feature] Emacs 29.x compatibility #157
Conversation
Credits to @ymarco for the symlink approach and code. Pros : doesn't require changing the release tarball structure (yet); Cons: doesn't work very well (or at all) on Windows. |
Fixed by making plain old copies on Windows. |
Please consider for merging, or suggest improvements? |
The code looks good from a quick review, but I wanna let @ubolonton decide how we wanna proceed with supporting treesit in emacs 29. |
Has there been any discussion or progress on this? Looks like Emacs 29.1 is approaching release now |
Any interest in getting this merged? Emacs 29.1 was released last year. |
This looked like a good change -- I wonder why it was closed? Would love to have this great set of language grammars available for built-in emacs treesit. |
@domq why close this? |
Let's face it: tree-sitter is a dead project. These days one should use the merged version of it, now called treesit inside the Emacs source tree. |
@domq That's kinda sad to hear. While I think/hope that the built-in treesit is the future, tree-sitter will still have value for some time if you ask me. Most of the treesit based |
The builtin treesit modes do not yet have feature parity with major modes and there is some functionality available in emacs-tree-sitter not yet available in builtin treesit. That said, it is IMO not a good idea to have two parallel tree-sitter implementations with different user-facing APIs. This will make things harder for downstream plugins that use "tree-sitter". Hopefully the builtin modes get better soon. |
A stab at #144.
libtree-sitter-LANG.so
toLANG.so
(orlibtree-sitter-LANG.dylib
toLANG.dylib
on Darwin, etc) — Based on @ymarco's work in Hacky support for treesit in Emacs core #99treesit-extra-load-path
if that variable exists