Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Enable use with Emacs 29's built-in tree-sitter modes #144

Open
denisw opened this issue Dec 8, 2022 · 4 comments
Open

Request: Enable use with Emacs 29's built-in tree-sitter modes #144

denisw opened this issue Dec 8, 2022 · 4 comments

Comments

@denisw
Copy link

denisw commented Dec 8, 2022

Emacs 29 will come with built-in support for tree-sitter, but doesn't seem to ship any grammar binaries, not even those needed by the provided major modes (e.g., typescript-ts-mode).

tree-sitter-langs would be a great way to install those grammars, but it would need two tweaks to work out of the box:

  • The bin directory would need to be appended to the treesit-extra-load-path list.
  • The binaries are currently named ${lang}.so / ${lang}.dylib, but Emacs' tree-sitter code expects the original libtree-sitter-${lang}.so / libtree-sitter-${lang}.dylib naming.

Would you be interested in making these tweaks to make tree-sitter-langs work with the built-in Tree Sitter support as well?

@meain
Copy link
Member

meain commented Dec 9, 2022

There is an open PR for this at #99

@denisw
Copy link
Author

denisw commented Dec 9, 2022

@meain Thanks for the link, I didn‘t see that PR. It seems to be more ambitious, though, in that it also tries to integrate the highlight patterns. Focusing on the binaries only could be a less tricky first step that would already provide tons of value to Emacs 29 users.

@domq
Copy link

domq commented Jan 5, 2023

Focusing on the binaries only could be a less tricky first step that would already provide tons of value to Emacs 29 users.

@denisw: kindly consider #157 that does just that.

@l2dy
Copy link

l2dy commented Sep 15, 2024

FYI, there is https://github.com/emacs-tree-sitter/treesit-langs for the new treesit.el.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants