Free decoder packet and improve decoder destructor

elixir-webrtc · Jan 20, 2024 · 36deb29 · 36deb29
1 parent 22b0812
commit 36deb29
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/c_src/xav/decoder.c b/c_src/xav/decoder.c
@@ -79,4 +79,14 @@ int decoder_decode(struct Decoder *decoder, AVPacket *pkt, AVFrame *frame) {
   }
 
   return 0;
+}
+
+void decoder_free(struct Decoder *decoder) {
+  if (decoder->swr_ctx != NULL) {
+    swr_free(&decoder->swr_ctx);
+  }
+
+  if (decoder->c != NULL) {
+    avcodec_free_context(&decoder->c);
+  }
 }
diff --git a/c_src/xav/xav_nif.c b/c_src/xav/xav_nif.c
@@ -186,20 +186,20 @@ ERL_NIF_TERM decode(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[]) {
   }
 
   av_frame_free(&frame);
+  av_packet_free(&pkt);
   return xav_nif_ok(env, frame_term);
 }
 
 void free_reader(ErlNifEnv *env, void *obj) {
+  XAV_LOG_DEBUG("Freeing Reader object");
   struct Reader *reader = (struct Reader *)obj;
   reader_free(reader);
 }
 
 void free_decoder(ErlNifEnv *env, void *obj) {
   XAV_LOG_DEBUG("Freeing Decoder object");
   struct Decoder *decoder = (struct Decoder *)obj;
-  if (decoder->c) {
-    avcodec_free_context(&decoder->c);
-  }
+  decoder_free(decoder);
 }
 
 static ErlNifFunc xav_funcs[] = {{"new_reader", 3, new_reader},