fixed unique_ptr::reset() instructions order. Internal pointer must b…

…e updated before deleting object (#373)
electronicarts · Jun 9, 2020 · d84b9c6 · d84b9c6
1 parent d996510
commit d84b9c6
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/include/EASTL/unique_ptr.h b/include/EASTL/unique_ptr.h
@@ -210,10 +210,8 @@ namespace eastl
 		{
 			if (pValue != mPair.first())
 			{
-				if (mPair.first())
-					get_deleter()(mPair.first());
-
-				mPair.first() = pValue;
+				if (auto first = exchange(mPair.first(), pValue))
+					get_deleter()(first);
 			}
 		}
 

diff --git a/test/source/TestSmartPtr.cpp b/test/source/TestSmartPtr.cpp
@@ -392,6 +392,20 @@ namespace SmartPtrTest
 		int mX;
 	};
 
+	struct CheckUPtrEmptyInDestructor
+	{
+		~CheckUPtrEmptyInDestructor()
+		{
+			if(mpUPtr)
+				mCheckUPtrEmpty = (*mpUPtr == nullptr);
+		}
+
+		eastl::unique_ptr<CheckUPtrEmptyInDestructor>* mpUPtr{};
+		static bool mCheckUPtrEmpty;
+	};
+
+	bool CheckUPtrEmptyInDestructor::mCheckUPtrEmpty = false;
+
 } // namespace SmartPtrTest
 
 
@@ -542,6 +556,16 @@ static int Test_unique_ptr()
 		}
 	}
 
+	{
+		// Test that unique_ptr internal pointer is reset before calling the destructor
+		CheckUPtrEmptyInDestructor::mCheckUPtrEmpty = false;
+
+		unique_ptr<CheckUPtrEmptyInDestructor> uptr(new CheckUPtrEmptyInDestructor);
+		uptr->mpUPtr = &uptr;
+		uptr.reset();
+		EATEST_VERIFY(CheckUPtrEmptyInDestructor::mCheckUPtrEmpty);
+	}
+
 	{
 		#if EASTL_CORE_ALLOCATOR_ENABLED
 			// Test EA::Allocator::EASTLICoreDeleter usage within eastl::shared_ptr.