fix bitvector iterators (#358)

* fix bitvector iterators use mContainer.begin() instead of &mContainer[0], since it causes out of bounds exception in non release build * test for empty bit vector comparison and iterator
electronicarts · Apr 23, 2020 · d996510 · d996510
1 parent 73e1685
commit d996510
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/include/EASTL/bitvector.h b/include/EASTL/bitvector.h
@@ -766,23 +766,23 @@ namespace eastl
 	typename bitvector<Allocator, Element, Container>::iterator
 	bitvector<Allocator, Element, Container>::begin() EA_NOEXCEPT
 	{
-		return iterator(&mContainer[0], 0);
+		return iterator(mContainer.begin(), 0);
 	}
 
 
 	template <typename Allocator, typename Element, typename Container>
 	typename bitvector<Allocator, Element, Container>::const_iterator
 	bitvector<Allocator, Element, Container>::begin() const EA_NOEXCEPT
 	{
-		return const_iterator(&mContainer[0], 0);
+		return const_iterator(mContainer.begin(), 0);
 	}
 
 
 	template <typename Allocator, typename Element, typename Container>
 	typename bitvector<Allocator, Element, Container>::const_iterator
 	bitvector<Allocator, Element, Container>::cbegin() const EA_NOEXCEPT
 	{
-		return const_iterator(&mContainer[0], 0);
+		return const_iterator(mContainer.begin(), 0);
 	}
 
 

diff --git a/test/source/TestBitVector.cpp b/test/source/TestBitVector.cpp
@@ -165,6 +165,11 @@ int TestBitVector()
 
 			bv0.assign(boolArray, boolArray + EAArrayCount(boolArray));
 			EATEST_VERIFY(bv0 == bitvector<>(boolArray, boolArray + EAArrayCount(boolArray)));
+
+			bv0.resize(0);
+			EATEST_VERIFY(bv0.begin()==bv0.end());//should not crash
+			bv3.resize(0);
+			EATEST_VERIFY(bv0 == bv3);
 		}
 	}