[ML] Portability improvements #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace calls to unix like commands with either CMake commands or the appropriate command for the native platform. Relates elastic#2311
droberts195
reviewed
Jun 17, 2022
Co-authored-by: David Roberts <[email protected]>
… into portability_improvements
|
retest |
Pulling Eigen at build time is problematic for parallel build as it introduces a race condition. The safer option is to pull at configuration time.
Remove the call to the eigen target in the build.gradle file as it no longer exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to unix like commands with either CMake commands or the
appropriate command for the native platform.
Relates #2311