[Searchprofiler] Fix CTA not being shown when screen is not tall enough #206764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]Async chunks
cc @sabarasaba |
SoniaSanzV
approved these changes
Jan 15, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
…gh (elastic#206764) (cherry picked from commit c3b9466)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
…l enough (#206764) (#206896) # Backport This will backport the following commits from `main` to `8.x`: - [[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)](#206764) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:27:12Z","message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Search Profiler","v9.0.0","backport:prev-minor"],"title":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough","number":206764,"url":"https://github.com/elastic/kibana/pull/206764","mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206764","number":206764,"mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <[email protected]>
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jan 22, 2025
…gh (elastic#206764) (cherry picked from commit c3b9466)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jan 22, 2025
…gh (elastic#206764) (cherry picked from commit c3b9466)
sabarasaba
added a commit
that referenced
this pull request
Jan 22, 2025
…ll enough (#206764) (#207834) # Backport This will backport the following commits from `main` to `8.17`: - [[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)](#206764) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:27:12Z","message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Search Profiler","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0","v8.18.0"],"title":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough","number":206764,"url":"https://github.com/elastic/kibana/pull/206764","mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206764","number":206764,"mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/206896","number":206896,"state":"MERGED","mergeCommit":{"sha":"d824cd242abbb8e4c31ade640445640a59357e43","message":"[8.x] [Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764) (#206896)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Searchprofiler] Fix CTA not being shown when screen is not tall\nenough (#206764)](https://github.com/elastic/kibana/pull/206764)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Ignacio\nRivas\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-16T08:27:12Z\",\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Kibana\nManagement\",\"release_note:skip\",\"Feature:Search\nProfiler\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"[Searchprofiler] Fix\nCTA not being shown when screen is not tall\nenough\",\"number\":206764,\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"number\":206764,\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Ignacio Rivas <[email protected]>"}}]}] BACKPORT-->
sabarasaba
added a commit
that referenced
this pull request
Jan 22, 2025
…ll enough (#206764) (#207835) # Backport This will backport the following commits from `main` to `8.16`: - [[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)](#206764) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:27:12Z","message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Search Profiler","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0","v8.18.0"],"title":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough","number":206764,"url":"https://github.com/elastic/kibana/pull/206764","mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206764","number":206764,"mergeCommit":{"message":"[Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/206896","number":206896,"state":"MERGED","mergeCommit":{"sha":"d824cd242abbb8e4c31ade640445640a59357e43","message":"[8.x] [Searchprofiler] Fix CTA not being shown when screen is not tall enough (#206764) (#206896)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Searchprofiler] Fix CTA not being shown when screen is not tall\nenough (#206764)](https://github.com/elastic/kibana/pull/206764)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Ignacio\nRivas\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-16T08:27:12Z\",\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Kibana\nManagement\",\"release_note:skip\",\"Feature:Search\nProfiler\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"[Searchprofiler] Fix\nCTA not being shown when screen is not tall\nenough\",\"number\":206764,\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"number\":206764,\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix CTA not being shown when screen is not tall enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Ignacio Rivas <[email protected]>"}}]}] BACKPORT-->
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #197698
Summary
Fix a small bug that happens when resizing the browser height, resulting in the Profile CTA not being shown.
// Before
Screen.Recording.2025-01-15.at.15.00.57.mov
// After
Screen.Recording.2025-01-15.at.15.00.24.mov