Skip to content

Commit

Permalink
[8.17] [Searchprofiler] Fix CTA not being shown when screen is not ta…
Browse files Browse the repository at this point in the history
…ll enough (#206764) (#207834)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Searchprofiler] Fix CTA not being shown when screen is not tall
enough (#206764)](#206764)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:27:12Z","message":"[Searchprofiler]
Fix CTA not being shown when screen is not tall enough
(#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Feature:Search
Profiler","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0","v8.18.0"],"title":"[Searchprofiler]
Fix CTA not being shown when screen is not tall
enough","number":206764,"url":"https://github.com/elastic/kibana/pull/206764","mergeCommit":{"message":"[Searchprofiler]
Fix CTA not being shown when screen is not tall enough
(#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206764","number":206764,"mergeCommit":{"message":"[Searchprofiler]
Fix CTA not being shown when screen is not tall enough
(#206764)","sha":"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/206896","number":206896,"state":"MERGED","mergeCommit":{"sha":"d824cd242abbb8e4c31ade640445640a59357e43","message":"[8.x]
[Searchprofiler] Fix CTA not being shown when screen is not tall enough
(#206764) (#206896)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.x`:\n- [[Searchprofiler] Fix CTA not being
shown when screen is not tall\nenough
(#206764)](https://github.com/elastic/kibana/pull/206764)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Ignacio\nRivas\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-16T08:27:12Z\",\"message\":\"[Searchprofiler]\nFix
CTA not being shown when screen is not tall
enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Kibana\nManagement\",\"release_note:skip\",\"Feature:Search\nProfiler\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"[Searchprofiler]
Fix\nCTA not being shown when screen is not
tall\nenough\",\"number\":206764,\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix
CTA not being shown when screen is not tall
enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/206764\",\"number\":206764,\"mergeCommit\":{\"message\":\"[Searchprofiler]\nFix
CTA not being shown when screen is not tall
enough\n(#206764)\",\"sha\":\"c3b9466de6b3bc03a74fc433ee77aec8c3f291a9\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Ignacio Rivas <[email protected]>"}}]}] BACKPORT-->
  • Loading branch information
sabarasaba authored Jan 22, 2025
1 parent 965b961 commit 7216205
Showing 1 changed file with 15 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import React, { useRef, memo, useCallback, useState } from 'react';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
import {
EuiForm,
EuiFieldText,
Expand Down Expand Up @@ -87,7 +88,14 @@ export const ProfileQueryEditor = memo(() => {
const licenseEnabled = getLicenseStatus().valid;

return (
<EuiFlexGroup responsive={false} gutterSize="none" direction="column">
<EuiFlexGroup
responsive={false}
gutterSize="none"
direction="column"
css={css`
height: 100%;
`}
>
{/* Form */}
<EuiFlexItem grow={false}>
<EuiForm>
Expand Down Expand Up @@ -115,7 +123,12 @@ export const ProfileQueryEditor = memo(() => {
</EuiFlexItem>

{/* Editor */}
<EuiFlexItem grow={10}>
<EuiFlexItem
grow={1}
css={css`
overflow: hidden;
`}
>
<Editor
onEditorReady={onEditorReady}
setEditorValue={setEditorValue}
Expand Down

0 comments on commit 7216205

Please sign in to comment.