Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fortinet Fortigate] Add url parsing error handling #12895

Merged
merged 9 commits into from
Mar 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/fortinet_fortigate/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.30.0"
changes:
- description: If url parsing fails, append failure message to error.message.
type: enhancement
link: https://github.com/elastic/integrations/pull/12895
- version: "1.29.2"
changes:
- description: Updated SSL description to be uniform and to include links to documentation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,10 @@ processors:
target_field: url
keep_original: false
if: ctx.fortinet?.firewall?.url != null
on_failure:
- append:
field: error.message
value: "url parsing failed with message {{ _ingest.on_failure_message }}"
# Need to do a set, then remove since rename w/ override
# is not supported in 8.3.0
- set:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ processors:
target_field: url
keep_original: false
if: ctx.fortinet?.firewall?.url != null
on_failure:
- append:
field: error.message
value: "url parsing failed with message {{ _ingest.on_failure_message }}"
- remove:
field: fortinet.firewall.url
ignore_missing: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,10 @@ processors:
target_field: url
keep_original: false
if: ctx.fortinet?.firewall?.url != null
on_failure:
- append:
field: error.message
value: "url parsing failed with message {{ _ingest.on_failure_message }}"
# Need to do a set, then remove since rename w/ override
# is not supported in 8.3.0
- set:
Expand Down
2 changes: 1 addition & 1 deletion packages/fortinet_fortigate/manifest.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: fortinet_fortigate
title: Fortinet FortiGate Firewall Logs
version: "1.29.2"
version: "1.30.0"
description: Collect logs from Fortinet FortiGate firewalls with Elastic Agent.
type: integration
format_version: "3.0.3"
Expand Down