-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fortinet Fortigate] Add url parsing error handling #12895
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused, the description says this will store the original url under url.original
, but I'm only seeing us appending to error.message
. Does uri_parts failing automatically put the original url under url.original
?
sorry about that. I updated the PR message late. I have added additional detail and sample output. |
|
💚 Build Succeeded
History
|
Package fortinet_fortigate - 1.30.0 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.30.0/ |
Proposed commit message
This PR adds error message for Fortinet Firewall if url parsing fails parsing
https://github.com/elastic/sdh-beats/issues/5691
The test file was removed since
elastic-package
cannot handle the test data witherror.message
field.update
Instead of generating a dedicated field, I choose to populate the error message as it displays the original url.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots