Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs-logging URL attributes #3150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ecs-logging URL attributes #3150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b9e9f0
add ecs-logging url attributes
colleenmcginnis Dec 19, 2024
49d3161
Merge branch 'master' into ecs-logging-url-attributes
colleenmcginnis Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions shared/attributes.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,28 @@ Issue and pull request URLs
:apm-issue: {apm-repo}issues/
:apm-pull: {apm-repo}pull/
:kibana-blob: {kib-repo}blob/{branch}/

:ecs-logging-ruby-repo: https://github.com/elastic/ecs-logging-ruby
:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main

Drive by comment that if you want "main" to be branch-specific you could maybe use {branch} or put these in the version-specific files.

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use {branch}

That's what I did initially but it didn't work locally (it was subbing 8.17).

put these in the version-specific files

We already have attributes for ECS logging in the version attribute files, but these use master because they are used in the elastic.co/guide URL attributes, but the branch name on GitHub is main. 🤔

:ecs-logging-python-repo: https://github.com/elastic/ecs-logging-python
:ecs-logging-python-blob: {ecs-logging-python-repo}/blob/main
:ecs-logging-php-repo: https://github.com/elastic/ecs-logging-php
:ecs-logging-php-blob: {ecs-logging-php-repo}/blob/main
:ecs-logging-nodejs-repo: https://github.com/elastic/ecs-logging-nodejs
:ecs-logging-nodejs-blob: {ecs-logging-nodejs-repo}/blob/main
:ecs-logging-java-repo: https://github.com/elastic/ecs-logging-java
:ecs-logging-java-blob: {ecs-logging-java-repo}/blob/{ecs-logging-java}
:ecs-logging-go-logrus-repo: https://github.com/elastic/ecs-logging-go-logrus
:ecs-logging-go-logrus-blob: {ecs-logging-go-logrus-repo}/blob/main
:ecs-logging-go-zap-repo: https://github.com/elastic/ecs-logging-go-zap
:ecs-logging-go-zap-blob: {ecs-logging-go-zap-repo}/blob/main
:ecs-logging-go-zerolog-repo: https://github.com/elastic/ecs-logging-go-zerolog
:ecs-logging-go-zerolog-blob: {ecs-logging-go-zerolog-repo}/blob/main
:ecs-logging-repo: https://github.com/elastic/ecs-logging
:ecs-logging-blob: {ecs-logging-repo}/blob/main
:ecs-dotnet-repo: https://github.com/elastic/ecs-dotnet
:ecs-dotnet-blob: {ecs-dotnet-repo}/blob/main

//////////
Legacy definitions
//////////
Expand Down
Loading