Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs-logging URL attributes #3150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

colleenmcginnis
Copy link
Contributor

Related to elastic/observability-docs#1393

Adds ECS logging GitHub URL attributes.

@colleenmcginnis colleenmcginnis self-assigned this Dec 19, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@@ -555,6 +555,28 @@ Issue and pull request URLs
:apm-issue: {apm-repo}issues/
:apm-pull: {apm-repo}pull/
:kibana-blob: {kib-repo}blob/{branch}/

:ecs-logging-ruby-repo: https://github.com/elastic/ecs-logging-ruby
:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main

Drive by comment that if you want "main" to be branch-specific you could maybe use {branch} or put these in the version-specific files.

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use {branch}

That's what I did initially but it didn't work locally (it was subbing 8.17).

put these in the version-specific files

We already have attributes for ECS logging in the version attribute files, but these use master because they are used in the elastic.co/guide URL attributes, but the branch name on GitHub is main. 🤔

@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 7, 2025 16:36
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner January 7, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants