-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecs-logging URL attributes #3150
base: master
Are you sure you want to change the base?
Add ecs-logging URL attributes #3150
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
@@ -555,6 +555,28 @@ Issue and pull request URLs | |||
:apm-issue: {apm-repo}issues/ | |||
:apm-pull: {apm-repo}pull/ | |||
:kibana-blob: {kib-repo}blob/{branch}/ | |||
|
|||
:ecs-logging-ruby-repo: https://github.com/elastic/ecs-logging-ruby | |||
:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:ecs-logging-ruby-blob: {ecs-logging-ruby-repo}/blob/main
Drive by comment that if you want "main" to be branch-specific you could maybe use {branch} or put these in the version-specific files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use {branch}
That's what I did initially but it didn't work locally (it was subbing 8.17
).
put these in the version-specific files
We already have attributes for ECS logging in the version attribute files, but these use master
because they are used in the elastic.co/guide
URL attributes, but the branch name on GitHub is main
. 🤔
Related to elastic/observability-docs#1393
Adds ECS logging GitHub URL attributes.