Fix certbot reload #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmirnow
force-pushed
the
fix-certbot-reload
branch
from
a09ab4e to
2f83296
Compare
|
Conflicts + linting failed. |
Certbot take care of all registred certificates by default. We should make use of it and not override this behaviour.
wsmirnow
force-pushed
the
fix-certbot-reload
branch
from
66801e7 to
5290275
Compare
|
Is fixed now. Please give it a try. |
This was referenced Jan 10, 2025
|
closes #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renew service should not be limited on one domain
Certbot take care of all registred certificates by default. We should make use of it and not override this behaviour.
This PR is based on #4 and should be merged in order. It also fixes #2.