-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: having released_languages tenant and site aware DS-553 #184
Conversation
f60f463
to
b3c793b
Compare
b3c793b
to
3bc273e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaferMazu did you deploy this changes in our olive platform? could we test it there or we need to test in local? |
All it's good for me, but I would like test it in a "production" environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in my local, and it's working as expected.
@Alec4r I don't have this in a staging environment. I will merge this according to the comments, but next time I'll upload it to the stage to make it easier to try. |
* feat: having released_languages tenant and site aware * fix: add darklangmiddleware backend for test * fix: correct the format of the language_options in the proxy
Description
This PR extract LC-V2 from the platform to eox-tenant.
LC-V2 allows you to have released_languages site aware in:
openedx/core/djangoapps/lang_pref/api.py
,openedx/core/djangoapps/dark_lang/middleware.py
. And set a default value to HTTP_ACCEPT_LANGUAGE.More context: LC-V2 Doc
Testing instructions
SetUp
How to test it
curl http://tenant-a.local.overhang.io:8000 -s 2>&1 | head -n 15
and you should see the LANGUAGE_CODE defined by site, for example in tenant-a is es-419. (Testing the default HTTP, and also the middleware)Additional information
Implementation
About this feature
Checklist for Merge