refactor: remove DarkLang middleware because it is not being used #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanDavidBuitrago
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
It looks good!
In what cases was it used before? @luisfelipec95 @MaferMazu
|
I'm not exactly sure why, but as a consequence of this PR eduNEXT/edunext-platform#697 the middleware is being modified here https://github.com/eduNEXT/edunext-platform/blob/master/openedx/core/djangoapps/dark_lang/middleware.py#L70 However, because of this post https://discuss.overhang.io/t/howto-enable-multiple-languages-for-your-open-edx-platform/140 SD is not using the middleware at all.
This is the screenshot of the productive manifest. That's why the PR is being made. |
luisfelipec95
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made to the PR #184 are made as the DarkLang middleware is no longer being used, detailed in the following discussion: https://discuss.overhang.io/t/howto-enable-multiple-languages-for-your-open-edx-platform/140.
Attached is evidence from SD where they are removing DarkLang Middleware: