feat: add engines model #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/add-engindes-tables
branch
from
9657b29
to
7ea5d42
Compare
johanseto
force-pushed
the
jlc/add-engindes-tables
branch
from
7ea5d42
to
51bdd2d
Compare
feat: add test utils feat: add tests
johanseto
force-pushed
the
jlc/add-engindes-tables
branch
from
51bdd2d
to
4213df7
Compare
andrey-canon
requested changes
Oct 2, 2024
eox_nelp/pearson_vue/models.py
Outdated
Comment on lines
77
to
78
| rti_courses = models.JSONField(default=dict) | ||
| ead_courses = models.JSONField(default=dict) |
There was a problem hiding this comment.
what is the difference between ead_course and rti_courses? I know that rti includes a cdd request, but basically a rti request is cdd+ ead
do we need that course information ? why the course is so important ?
eox_nelp/pearson_vue/models.py
Outdated
Comment on lines
151
to
155
| if action.lower() == 'rti': | ||
| return self.rti_courses | ||
|
|
||
| if action.lower() == 'ead': | ||
| return self.ead_courses |
There was a problem hiding this comment.
I'm still confused about these courses
|
@andrey-canon I unify the courses section for RTI and EAD. |
andrey-canon
approved these changes
Oct 25, 2024
eox_nelp/pearson_vue/utils.py
Outdated
|
|
||
|
|
||
| def update_user_engines(user, action_type, course_id=None): | ||
| """_summary_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add engines records model
Testing instructions
migrate
check admin engines
you could the util to modify engines
Additional information
jira story