Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jlc/update engines #217

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Jlc/update engines #217

merged 2 commits into from
Oct 28, 2024

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Sep 26, 2024 •
edited
Loading

Description

This PR depend of engines model PR.
#219

Testing instructions

  • Send engines requests of person.
  • Check the engines are updated at expected.
Screencast.from.01-10-24.12.01.32.webm
Jira story

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@johanseto johanseto changed the base branch from master to jlc/add-engindes-tables September 30, 2024 23:47
@github-actions github-actions bot added size/s and removed size/m m lines label labels Oct 1, 2024
@johanseto johanseto changed the title Jlc/update engine reg info Jlc/update engines Oct 1, 2024
@johanseto johanseto marked this pull request as ready for review October 1, 2024 16:53
andrey-canon
andrey-canon approved these changes Oct 25, 2024
View reviewed changes
eox_nelp/pearson_vue/tests/test_tasks.py Outdated Show resolved Hide resolved
eox_nelp/pearson_vue/tests/test_tasks.py Outdated Show resolved Hide resolved
eox_nelp/pearson_vue/tests/test_tasks.py Outdated Show resolved Hide resolved
@johanseto johanseto changed the base branch from jlc/add-engindes-tables to master October 28, 2024 23:29
johanseto and others added 2 commits October 28, 2024 18:32
@johanseto
feat: update user engine custom form data
b375a68 
feat: update engine custom form before engine sent
@johanseto @andrey-canon
chore: apply suggestions from code review
4885e02 
Co-authored-by: Andrey Cañon <[email protected]>
@johanseto johanseto merged commit 74b58da into master Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-canon andrey-canon andrey-canon approved these changes

Assignees
No one assigned
Labels
size/s test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanseto @andrey-canon