Auto-update snapshot tests if changing strings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special incantation to update snapshots is tough to remember and non-obvious to many folks who are just updating text copy in the app. This makes the CI workflow auto-update snapshot tests on pull requests (not other pushes) where there were changes to the english strings. It's possible this could make tests pass when they shouldn't (if other things that should not have changed were changed), so it also posts a comment to the PR if it had to update the snapshots that reminds a reviewer to check the snapshot changes.
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
09c7767 to
542dc2e
Compare
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
5e3b6c3 to
e24f593
Compare
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
609d5c4 to
0d47ba1
Compare
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
b53366f to
89403b9
Compare
|
👋 FYI, your PR has been automatically updated with changes to |
|
🚨 The "snapshot" tests in your PR have been automatically updated because you changed some text in the app! Make sure the changes to |
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
2219996 to
8aa7cdc
Compare
|
🚨 The "snapshot" tests in your PR have been automatically updated because you changed some text in the app! Make sure the changes to |
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
fba3909 to
9bd2710
Compare
Mr0grog
force-pushed
the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
from
4cdd143 to
4e21b7e
Compare
Mr0grog
deleted the
text-edits-it-turns-out-you-need-to-regenerate-snapshots-a-lot-and-its-a-problem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special incantation to update snapshots is tough to remember and non-obvious to many folks who are just updating text copy in the app. This makes the CI workflow auto-update snapshot tests on pull requests (not other pushes) where there were changes to the english strings. It's possible this could make tests pass when they shouldn't (if other things that should not have changed were changed), so it also posts a comment to the PR if it had to update the snapshots that reminds a reviewer to check the snapshot changes.