Skip to content

Commit

Permalink
Add a little teaching info to PR comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Mr0grog committed Feb 22, 2025
1 parent e647056 commit 4e21b7e
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/build-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ concurrency:

env:
node-version: 18
english-strings: client/src/intl/en.json

jobs:
build:
Expand Down Expand Up @@ -88,7 +89,7 @@ jobs:
with:
filters: |
english:
- client/src/intl/en.json
- ${{ env.english-strings }}
- name: Unit tests
env:
Expand Down Expand Up @@ -122,6 +123,9 @@ jobs:
to `.snap` files](${{ env.commit_url }}) are correct** and don’t
include other things that should *not* have changed.
You can also update snapshot tests yourself when working locally by
running `npm run test:update` on the command line.
lint:
runs-on: ubuntu-latest
defaults:
Expand Down Expand Up @@ -187,16 +191,16 @@ jobs:
if: github.event_name == 'pull_request'
with:
commit_message: 'Auto-update en.json from component source code'
file_pattern: 'client/src/intl/en.json'
file_pattern: '${{ env.english-strings }}'

- name: Comment on the PR about changes
uses: thollander/actions-comment-pull-request@v3
if: steps.commit-strings.outputs.changes_detected == 'true'
with:
message: >
:wave: FYI, your PR has been automatically updated with changes to
`client/src/intl/en.json`, which contains all the translatable text
from the application (probably because you made changes to
`${{ env.english-strings }}`, which contains all the translatable
text from the application (probably because you made changes to
the text of a component without updating this file).
- name: Check Spanish translations
Expand Down

0 comments on commit 4e21b7e

Please sign in to comment.