Skip to content

CCE on selecting "Show remaining..." in JUnit view #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2023
Merged

CCE on selecting "Show remaining..." in JUnit view #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,19 +1154,18 @@ void handleExpandableNodeClicked(Widget w) {
createTreeItem(parent, element, -1);
}

// If we've expanded but still have not reached the limit
// select new expandable node, so user can click through
// to the end
// reset the selection. client's selection listener should not be triggered.
// there was only one selection on Expandable Node.
Item[] curSel = tree.getSelection();
if (curSel.length == 1) {
tree.deselect((TreeItem) curSel[0]);
}

// Scroll to the last element, so user can see what's expanded
// end continue expanding if needed
Object lastElement = getLastElement(parent);
if (lastElement instanceof ExpandableNode node) {
setSelection(new StructuredSelection(node), true);
} else {
// reset the selection. client's selection listener should not be triggered.
// there was only one selection on Expandable Node.
Item[] curSel = tree.getSelection();
if (curSel.length == 1) {
tree.deselect((TreeItem) curSel[0]);
}
if (lastElement instanceof ExpandableNode) {
reveal(lastElement);
}
} finally {
tree.setRedraw(true);
Expand Down