CCE on selecting "Show remaining..." in JUnit view #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCE happens because we always select expandable node on click and because the JUnit related selection listener code queries the selection from the widget instead of using selection from selection event while reacting on selection change. This is unusual, but allowed. However, setting selection in first place is actually not needed, the only reason to do so was to reveal last element after expanding, so that user can simply click few times if needed. Revealing shown items however can be done without selection, so we don't run in such corner cases here. Fixes eclipse-platform#1360
|
19 Test fails are unrelated, see #1351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCE happens because we always select expandable node on click and because the JUnit related selection listener code queries the selection from the widget instead of using selection from selection event while reacting on selection change. This is unusual, but allowed.
However, setting selection in first place is actually not needed, the only reason to do so was to reveal last element after expanding, so that user can simply click few times if needed. Revealing shown items however can be done without selection, so we don't run in such corner cases here.
Fixes #1360