Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Release 0.11.0 #700

Merged
merged 27 commits into from
Mar 23, 2024
Merged

CRAN Release 0.11.0 #700

merged 27 commits into from
Mar 23, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (01eff88) to head (cc1342d).

Files Patch % Lines
R/check_model_diagnostics.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
+ Coverage   59.88%   60.26%   +0.37%     
==========================================
  Files          86       86              
  Lines        6252     6274      +22     
==========================================
+ Hits         3744     3781      +37     
+ Misses       2508     2493      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke

This comment was marked as resolved.

@strengejacke

This comment was marked as resolved.

@strengejacke

This comment was marked as resolved.

@strengejacke

This comment was marked as resolved.

@IndrajeetPatil
Copy link
Member

IndrajeetPatil commented Mar 21, 2024

I can't reproduce this locally. The only problem I see is the following, irrespective of whether parallel testing is on or not:

Error (test-logLik.R:8:3): logLik
<expressionStackOverflowError/stackOverflowError/error/condition>
Error: evaluation nested too deeply: infinite recursion / options(expressions=)?

@strengejacke
Copy link
Member Author

Thanks for testing! Could it be related that this code allows too many iterations/nesting?

withr::local_options(list(expressions = 25))

@IndrajeetPatil
Copy link
Member

I am not sure where that option is used but that's possible.

Are we sure that there is no circular referencing between our functions in this context: performance calls effectsize which calls performance, or something of that sort?

@strengejacke
Copy link
Member Author

I don't think so. insight is failing on win devel only, too, and this is new - I just submitted last weekend and everything was fine. On current windows, everything is ok for insight and performance, and for linux r devel, too. It must be something that recently changed, either a package update (I suspected glmmTMB because that example was failing, although it was just a simple model) or win-devel update.

@strengejacke
Copy link
Member Author

I just saw, the loglik test is skipped on CRAN, anyway, so can't be the cause.

@strengejacke
Copy link
Member Author

skipping all tests and examples that involve glmmTMB resolve the issues...

@strengejacke
Copy link
Member Author

See glmmTMB/glmmTMB#1007 (comment)

@strengejacke
Copy link
Member Author

Will submit next week.

@strengejacke strengejacke merged commit 80b5b2f into main Mar 23, 2024
23 of 26 checks passed
@strengejacke strengejacke deleted the rc_0_11_0 branch March 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants