-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Release 0.11.0 #700
CRAN Release 0.11.0 #700
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 59.88% 60.26% +0.37%
==========================================
Files 86 86
Lines 6252 6274 +22
==========================================
+ Hits 3744 3781 +37
+ Misses 2508 2493 -15 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I can't reproduce this locally. The only problem I see is the following, irrespective of whether parallel testing is on or not: Error (test-logLik.R:8:3): logLik
<expressionStackOverflowError/stackOverflowError/error/condition>
Error: evaluation nested too deeply: infinite recursion / options(expressions=)? |
Thanks for testing! Could it be related that this code allows too many iterations/nesting? withr::local_options(list(expressions = 25)) |
I am not sure where that option is used but that's possible. Are we sure that there is no circular referencing between our functions in this context: performance calls effectsize which calls performance, or something of that sort? |
I don't think so. insight is failing on win devel only, too, and this is new - I just submitted last weekend and everything was fine. On current windows, everything is ok for insight and performance, and for linux r devel, too. It must be something that recently changed, either a package update (I suspected glmmTMB because that example was failing, although it was just a simple model) or win-devel update. |
I just saw, the loglik test is skipped on CRAN, anyway, so can't be the cause. |
skipping all tests and examples that involve glmmTMB resolve the issues... |
Will submit next week. |
No description provided.