Fix the Node/Item XDM Relationship #3409

adamretter · 2020-05-12T19:07:12Z

Small enhancement built on #3363

But... it changes the on-disk format of the Native Value Index (values.dbx), and so requires a major release.

line-o

Please also revert the integer value of NO_SUCH_VALUE back to -1

adamretter · 2020-05-12T20:52:01Z

@line-o I don't think that needs to be done.

line-o · 2020-05-12T20:54:21Z

It makes much more sense to have it as -1, when it is the only negative value. Comparable to ['a' , 'b'].indexOf('c')

adamretter · 2020-05-12T22:22:33Z

@line-o That's one perspective... feel free to send a follow-up PR.

dizzzz · 2020-06-15T10:35:17Z

What is the status of the PR?

joewiz · 2021-01-12T19:00:45Z

@dizzzz When you have the chance could you restart the AppVeyor CI on this PR? Thanks!

dizzzz · 2021-01-13T07:27:34Z

sorry...

probably if we rebase, a new build is triggered

sonarqubecloud · 2021-03-20T21:30:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

exist-core/src/main/java/org/exist/xquery/value/Type.java

line-o · 2023-02-13T19:52:45Z

NO_SUCH_VALUE was changed from -1 to -99 in 3102f46
I would like the reordering of Value types to include this to be -1 again.

reinhapa · 2023-02-14T12:38:09Z

exist-core/src/main/java/org/exist/xquery/value/Type.java

-    private final static Int2ObjectOpenHashMap<String[]> typeNames = new Int2ObjectOpenHashMap<>(64, Hash.FAST_LOAD_FACTOR);
-    private final static Object2IntOpenHashMap<String> typeCodes = new Object2IntOpenHashMap<>(100, Hash.FAST_LOAD_FACTOR);
+    // Tombstone value used for FastUtil Int maps
+    private static final int NO_SUCH_VALUE = -99;


@adamretter why is this value -99 in this case? I this a related to the FastUtil API?

Can the tombstone value be -1 as well?

I just tested this. There is no technical reason to leave it at -99 the tests all pass with -1 as well.

Indeed, there is no technical reason why it is -1 or -99, technically it makes no difference. To be clear, I have never claimed otherwise. The reason it was changed was for human reasons:

When looking at it as an integer value it is much easier to spot.

When looking at it as an unsigned binary value the wrap causes it to look similar to other valid values, whereas -99 was an easier pattern to spot.

Both of these were factors as to why I changed it whilst developing and debugging this code. As it technically makes no difference, I suggest leaving it as -99 to assist the humans that will likely have to work on this code in future.

Not convinced -1 is very different from the other values as it is the only negative value.

As the person who actually did the work on this and spent time debugging and fixing it when there were issues, I would hope that you would believe me when I am trying to tell you that I had problems spotting the -1 amongst other values, and that switching it to -99 made it easier to find the issues! As you did not do this work yourself, and did not have that experience personally, I find your comments perplexing!

As we agree that there is no technical advantage to changing the value, but that I have explained that there is a very real human advantage to leaving it as -99, please can you explain what your argument is for changing it to -1, i.e. What advantage do you see in changing this that causes you to be so insistent about it?

lets make it Integer.MIN_VALUE then

For what reason exactly?

line-o · 2023-02-14T15:03:29Z

I would propose to shift the current mapping of node types by one which would make the relationship quite clear as all
types that are subtypes of NODE would have a higher integer value;

    public static final int NODE = 1;
    public final static int ELEMENT = 2;
    public final static int ATTRIBUTE = 3;
    public final static int TEXT = 4;
    public final static int PROCESSING_INSTRUCTION = 5;
    public final static int COMMENT = 6;
    public final static int DOCUMENT = 7;

line-o

The changes look good, from a first look. Ignore earlier comment, as it did not show the new commits at the time of writing.

adamretter · 2023-02-21T10:57:01Z

I would propose to shift the current mapping of node types by one which would make the relationship quite clear as all
types that are subtypes of NODE would have a higher integer value;

@line-o I am not sure if I understand what you are suggesting? At the moment in this PR I have:

    public final static int NODE = 56;
    public final static int ATTRIBUTE = 57;
    public final static int COMMENT = 58;
    public final static int DOCUMENT = 59;
    public final static int ELEMENT = 60;
    public final static int NAMESPACE = 61;
    public final static int PROCESSING_INSTRUCTION = 62;
    public final static int TEXT = 63;

It looks to me from the above that "all types that are subtypes of NODE" already "have a higher integer value" than NODE. Can you explain further what you were suggesting please?

line-o · 2023-02-21T11:48:52Z

The changes look good, from a first look. Ignore earlier comment, as it did not show the new commits at the time of writing.

@adamretter

Still wondering why -99 is so important. I will introduce a PR changing that if it is not done here.

line-o

What do you think?

line-o · 2023-02-21T15:22:35Z

exist-core/src/main/java/org/exist/xquery/value/Type.java

-    private final static Int2ObjectOpenHashMap<String[]> typeNames = new Int2ObjectOpenHashMap<>(64, Hash.FAST_LOAD_FACTOR);
-    private final static Object2IntOpenHashMap<String> typeCodes = new Object2IntOpenHashMap<>(100, Hash.FAST_LOAD_FACTOR);
+    // Tombstone value used for FastUtil Int maps
+    private static final int NO_SUCH_VALUE = -99;


lets make it Integer.MIN_VALUE then

reinhapa · 2023-02-28T15:11:23Z

@adamretter seem to have some license header problem, that needs to be fixed first

reinhapa · 2023-02-28T15:24:23Z

@adamretter there seem to be some license header problems left

line-o · 2023-02-28T15:28:30Z

I checked the unsigned binary values of

-1 : 1111111111111111
-99 : 1111111110011101
-2147483648 : 10000000000000000000000000000000

dizzzz · 2023-11-20T19:20:38Z

Needed

rebase
reformat
check tests

dizzzz · 2024-04-24T18:59:30Z

I'd like to see the PR pulled in as-is, the discussion is interesting (..) but not so important I'd say. Waste of time/energy....

adamretter · 2024-09-02T10:03:20Z

@dizzzz I have rebased it as you requested. It think it is now ready for you to merge.

reinhapa

The tests do not pass at all
Why where the shorter switch expressions being replaced with the old style?

reinhapa · 2024-09-02T15:07:38Z

exist-core/src/main/java/org/exist/xquery/value/AtomicValue.java

+            switch (requiredType) {
+                case Type.ANY_ATOMIC_TYPE:
+                case Type.ITEM:
+                case Type.STRING:
+                    return StringValue.EMPTY_STRING;
+                case Type.NORMALIZED_STRING:
+                case Type.TOKEN:
+                case Type.LANGUAGE:
+                case Type.NMTOKEN:
+                case Type.NAME:
+                case Type.NCNAME:
+                case Type.ID:
+                case Type.IDREF:
+                case Type.ENTITY:
+                    return new StringValue(getExpression(), "", requiredType);
+                case Type.ANY_URI:
+                    return AnyURIValue.EMPTY_URI;
+                case Type.BOOLEAN:
+                    return BooleanValue.FALSE;


Restore previous shorter switch version

reinhapa · 2024-09-02T15:10:43Z

exist-core/src/main/java/org/exist/xquery/value/AtomicValue.java

+                default:
+                    throw new XPathException(getExpression(), "cannot convert empty value to " + requiredType);
+            }


Use shorter switch style if possible

reinhapa · 2024-09-02T15:11:08Z

exist-core/src/main/java/org/exist/xquery/value/BooleanValue.java

+    public AtomicValue convertTo(final int requiredType) throws XPathException {
+        switch (requiredType) {
+            case Type.BOOLEAN:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return this;
+            case Type.NUMERIC:
+            case Type.INTEGER:
+                return new IntegerValue(getExpression(), value ? 1 : 0);
+            case Type.DECIMAL:
+                return new DecimalValue(getExpression(), value ? 1 : 0);
+            case Type.FLOAT:
+                return new FloatValue(getExpression(), value ? 1 : 0);
+            case Type.DOUBLE:
+                return new DoubleValue(getExpression(), value ? 1 : 0);
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.XPTY0004,
+                        "cannot convert 'xs:boolean(" + value + ")' to " + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:11:21Z

exist-core/src/main/java/org/exist/xquery/value/DateTimeValue.java

+    public AtomicValue convertTo(final int requiredType) throws XPathException {
+        switch (requiredType) {
+            case Type.DATE_TIME:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return this;
+            case Type.DATE_TIME_STAMP:
+                return new DateTimeStampValue(getExpression(), calendar);
+            case Type.DATE:
+                return new DateValue(getExpression(), calendar);
+            case Type.TIME:
+                return new TimeValue(getExpression(), calendar);
+            case Type.G_YEAR:
+                return new GYearValue(getExpression(), calendar);
+            case Type.G_YEAR_MONTH:
+                return new GYearMonthValue(getExpression(), calendar);
+            case Type.G_MONTH_DAY:
+                return new GMonthDayValue(getExpression(), calendar);
+            case Type.G_DAY:
+                return new GDayValue(getExpression(), calendar);
+            case Type.G_MONTH:
+                return new GMonthValue(getExpression(), calendar);
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001,
+                        "Type error: cannot cast xs:dateTime to "
+                                + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:11:42Z

exist-core/src/main/java/org/exist/xquery/value/DateValue.java

+    public AtomicValue convertTo(final int requiredType) throws XPathException {
+        switch (requiredType) {
+            case Type.DATE:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return this;
+            case Type.DATE_TIME:
+                return new DateTimeValue(getExpression(), calendar);
+            case Type.G_YEAR:
+                return new GYearValue(getExpression(), this.calendar);
+            case Type.G_YEAR_MONTH:
+                return new GYearMonthValue(getExpression(), calendar);
+            case Type.G_MONTH_DAY:
+                return new GMonthDayValue(getExpression(), calendar);
+            case Type.G_DAY:
+                return new GDayValue(getExpression(), calendar);
+            case Type.G_MONTH:
+                return new GMonthValue(getExpression(), calendar);
+            case Type.UNTYPED_ATOMIC: {
                final DateValue dv = new DateValue(getExpression(), getStringValue());
-                yield new UntypedAtomicValue(getExpression(), dv.getStringValue());
+                return new UntypedAtomicValue(getExpression(), dv.getStringValue());
            }
-            case Type.STRING -> {
+            case Type.STRING: {
                final DateValue dv = new DateValue(getExpression(), calendar);
-                yield new StringValue(getExpression(), dv.getStringValue());
+                return new StringValue(getExpression(), dv.getStringValue());
            }
-            default -> throw new XPathException(getExpression(), ErrorCodes.FORG0001, "can not convert " +
-                    Type.getTypeName(getType()) + "('" + getStringValue() + "') to " +
-                    Type.getTypeName(requiredType));
-        };
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001, "can not convert " +
+                        Type.getTypeName(getType()) + "('" + getStringValue() + "') to " +
+                        Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:17:18Z

exist-core/src/main/java/org/exist/xquery/value/GYearMonthValue.java

+        switch (requiredType) {
+            case Type.G_YEAR_MONTH:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return new GYearMonthValue(getExpression(), this.calendar);
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001,
+                        "Type error: cannot cast xs:time to "
+                                + Type.getTypeName(requiredType));


Restore previous shorter switch version

reinhapa · 2024-09-02T15:17:34Z

exist-core/src/main/java/org/exist/xquery/value/GYearValue.java

+        switch (requiredType) {
+            case Type.G_YEAR:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return this;
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001,
+                        "Type error: cannot cast xs:time to "
+                                + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:17:56Z

exist-core/src/main/java/org/exist/xquery/value/QNameValue.java

+        switch (requiredType) {
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+            case Type.QNAME:
+                return this;
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001,
+                        "A QName cannot be converted to " + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:18:12Z

exist-core/src/main/java/org/exist/xquery/value/TimeValue.java

+        switch (requiredType) {
+            case Type.TIME:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.ITEM:
+                return this;
 //		case Type.DATE_TIME :
 //			xs:time -> xs:dateTime conversion not defined in Funcs&Ops 17.1.5
-            case Type.STRING -> new StringValue(getExpression(), getStringValue());
-            case Type.UNTYPED_ATOMIC -> new UntypedAtomicValue(getExpression(), getStringValue());
-            default -> throw new XPathException(getExpression(), ErrorCodes.FORG0001,
-                    "Type error: cannot cast xs:time to "
-                            + Type.getTypeName(requiredType));
-        };
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.FORG0001,
+                        "Type error: cannot cast xs:time to "
+                                + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

reinhapa · 2024-09-02T15:18:41Z

exist-core/src/main/java/org/exist/xquery/value/YearMonthDurationValue.java

+        switch (requiredType) {
+            case Type.ITEM:
+            case Type.ANY_ATOMIC_TYPE:
+            case Type.YEAR_MONTH_DURATION:
+                return this;
+            case Type.STRING:
+                return new StringValue(getExpression(), getStringValue());
+            case Type.DURATION:
+                return new DurationValue(getExpression(), TimeUtils.getInstance().newDuration(
+                        duration.getSign() >= 0,
+                        (BigInteger) duration.getField(DatatypeConstants.YEARS),
+                        (BigInteger) duration.getField(DatatypeConstants.MONTHS),
+                        null, null, null, null
+                ));
+            case Type.DAY_TIME_DURATION:
+                return new DayTimeDurationValue(getExpression(), DayTimeDurationValue.CANONICAL_ZERO_DURATION);
            //case Type.DOUBLE:
            //return new DoubleValue(monthsValueSigned().doubleValue());
            //return new DoubleValue(Double.NaN);
            //case Type.DECIMAL:
            //return new DecimalValue(monthsValueSigned().doubleValue());
-            case Type.UNTYPED_ATOMIC -> new UntypedAtomicValue(getExpression(), getStringValue());
-            default -> throw new XPathException(getExpression(), ErrorCodes.XPTY0004,
-                    "cannot cast 'xs:yearMonthDuration(\"" + getStringValue() +
-                            "\")' to " + Type.getTypeName(requiredType));
-        };
+            case Type.UNTYPED_ATOMIC:
+                return new UntypedAtomicValue(getExpression(), getStringValue());
+            default:
+                throw new XPathException(getExpression(), ErrorCodes.XPTY0004,
+                        "cannot cast 'xs:yearMonthDuration(\"" + getStringValue() +
+                                "\")' to " + Type.getTypeName(requiredType));
+        }


Restore previous shorter switch version

…space, we can now fit all Types in 1 byte

…ype integer value, so we have to bump the storage format version

reinhapa · 2024-10-09T10:02:11Z

@adamretter there still testfailures

adamretter · 2024-10-09T10:18:11Z

there still testfailures
@reinhapa Yup - I am still tweaking it ;-)

adamretter · 2024-10-09T17:20:50Z

@reinhapa to answer your questions:

The tests do not pass at all

They should do now. I have split some things not related to Node/Item XDM Relationship out of this PR and will send them in a follow-up PR.

Why where the shorter switch expressions being replaced with the old style?

This is intentional, let me try and explain...

The "shorter switch expressions" (as you described them) are not readable when there are multiple values for the same case. The reason for this is they extend horizontally on a single line across the screen and make it impossible to understand easily or see the changes between two versions of the code. The "old style" (as you described them) instead is laid out on separate lines vertically and is much easier to read when you are considering what has changed between two or more versions.

Also when considering changes, consider that most diff tools are line based, and so putting it all onto one line stops a diff tool from clearly showing and/or highlighting small changes. For example here is a screenshot from a 2 version diff:

Now consider when you have a 3 version diff as is common when working with Git versions and tools like diffmerge. It becomes almost impossible to understand the changes when you have one long line in 3 different versions that are compared side by side. For example here is a screenshot from a 3 version diffmerge:

The "shorter switch expressions" are not bad per-se, but they are much much worse (i.e. less readable and understandable) by tools (like git, diff, or diffmerge, or humans) which are line based when you are comparing multiple versions. The reason for that is that when there are multiple case values they are laid out horizontally all on one line and that line often extends far off the viewable area on the screen.

Does that make sense?

dizzzz

LGTM (though I had one or 2 questions)

exist-core/src/main/java/org/exist/xquery/value/Type.java

dizzzz · 2024-10-10T05:55:57Z

thnx!

reinhapa · 2024-10-10T17:05:40Z

@reinhapa to answer your questions:
This is intentional, let me try and explain...

...

The "shorter switch expressions" are not bad per-se, but they are much much worse (i.e. less readable and understandable) by tools (like git, diff, or diffmerge, or humans) which are line based when you are comparing multiple versions. The reason for that is that when there are multiple case values they are laid out horizontally all on one line and that line often extends far off the viewable area on the screen.

Does that make sense?

I see your point of the problem when comparing. But this could be circumvented by still putting each value on on a seperate line but leave them on the same case label if realy needed but gaining the security of no fall-thru errors. Besides that it would be cool to have those types as Enum anyway in the future as a missing value would be detected already at compile time.

adamretter · 2024-10-10T17:12:41Z

would be cool to have those types as Enum anyway

Yes it would, I already did that in another branch on another project ;-)

adamretter added the enhancement new features, suggestions, etc. label May 12, 2020

adamretter added this to the eXist-6.0.0 milestone May 12, 2020

adamretter requested a review from a team May 12, 2020 19:07

line-o previously requested changes May 12, 2020

View reviewed changes

adamretter force-pushed the hotfix/number-comparisons-2 branch from 4c2eb67 to c4542b0 Compare March 20, 2021 21:05

adamretter modified the milestones: eXist-6.0.0, eXist-7.0.0 Feb 14, 2022

adamretter force-pushed the hotfix/number-comparisons-2 branch from c4542b0 to 1201eeb Compare February 5, 2023 21:31

reinhapa reviewed Feb 11, 2023

View reviewed changes

exist-core/src/main/java/org/exist/xquery/value/Type.java Outdated Show resolved Hide resolved

adamretter force-pushed the hotfix/number-comparisons-2 branch from 1201eeb to 1af7f65 Compare February 14, 2023 11:03

reinhapa approved these changes Feb 14, 2023

View reviewed changes

line-o reviewed Feb 14, 2023

View reviewed changes

line-o self-requested a review February 21, 2023 11:49

line-o reviewed Feb 21, 2023

View reviewed changes

dizzzz approved these changes Feb 28, 2023

View reviewed changes

line-o self-requested a review February 28, 2023 15:26

adamretter force-pushed the hotfix/number-comparisons-2 branch from baaf242 to affb1fd Compare September 2, 2024 10:02

adamretter force-pushed the hotfix/number-comparisons-2 branch 2 times, most recently from 3fde20d to d82ddf8 Compare September 2, 2024 10:05

reinhapa requested changes Sep 2, 2024

View reviewed changes

adamretter added 6 commits October 9, 2024 02:10

[refactor] Rename constants

941ed79

[bugfix] Fix the Node/Item XDM Relationship

548f13c

[refactor] Just number Types sequentially to reduce the needed value …

ebc3f36

…space, we can now fit all Types in 1 byte

[doc] Add some comments about data type size

a4715f3

[feature] NativeValueIndex (values.dbx) stores the org.exist.xquery.T…

2a72d93

…ype integer value, so we have to bump the storage format version

[bugfix] Do not conflate Node Type with XDM Type

edc62fb

adamretter force-pushed the hotfix/number-comparisons-2 branch 2 times, most recently from 2ef6a14 to 756462c Compare October 9, 2024 08:02

reinhapa approved these changes Oct 9, 2024

View reviewed changes

adamretter force-pushed the hotfix/number-comparisons-2 branch from 7384f2d to ac6bc65 Compare October 9, 2024 10:06

[ignore] Cleanup

439307e

adamretter force-pushed the hotfix/number-comparisons-2 branch 2 times, most recently from f0733bc to 439307e Compare October 9, 2024 17:07

eXist-db deleted a comment from sonarqubecloud bot Oct 9, 2024

adamretter mentioned this pull request Oct 9, 2024

Fix further issues with number types #5485

Merged

dizzzz approved these changes Oct 9, 2024

View reviewed changes

exist-core/src/main/java/org/exist/xquery/value/Type.java Show resolved Hide resolved

dizzzz merged commit 4fcb864 into eXist-db:develop Oct 10, 2024
12 of 13 checks passed

Fix the Node/Item XDM Relationship #3409

Fix the Node/Item XDM Relationship #3409

Conversation

adamretter commented May 12, 2020 • edited Loading

line-o left a comment

Choose a reason for hiding this comment

adamretter commented May 12, 2020

line-o commented May 12, 2020

adamretter commented May 12, 2020

dizzzz commented Jun 15, 2020

joewiz commented Jan 12, 2021

dizzzz commented Jan 13, 2021 • edited Loading

sonarqubecloud bot commented Mar 20, 2021

line-o commented Feb 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

line-o Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamretter Feb 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

line-o commented Feb 14, 2023

line-o left a comment

Choose a reason for hiding this comment

adamretter commented Feb 21, 2023 • edited Loading

line-o commented Feb 21, 2023

line-o left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reinhapa commented Feb 28, 2023

reinhapa commented Feb 28, 2023

line-o commented Feb 28, 2023

dizzzz commented Nov 20, 2023

dizzzz commented Apr 24, 2024

adamretter commented Sep 2, 2024

reinhapa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reinhapa commented Oct 9, 2024

adamretter commented Oct 9, 2024

adamretter commented Oct 9, 2024 • edited Loading

dizzzz left a comment • edited Loading

Choose a reason for hiding this comment

dizzzz commented Oct 10, 2024

reinhapa commented Oct 10, 2024

adamretter commented Oct 10, 2024

adamretter commented May 12, 2020 •

edited

Loading

dizzzz commented Jan 13, 2021 •

edited

Loading

line-o Feb 14, 2023 •

edited

Loading

adamretter Feb 21, 2023 •

edited

Loading

adamretter commented Feb 21, 2023 •

edited

Loading

adamretter commented Oct 9, 2024 •

edited

Loading

dizzzz left a comment •

edited

Loading