[doc] Added a note about future work that needs to consider the cases…

… where the convert is doing nothing
eXist-db · Sep 2, 2024 · d82ddf8 · d82ddf8
1 parent 079ce89
commit d82ddf8
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/exist-core/src/main/java/org/exist/xquery/UntypedValueCheck.java b/exist-core/src/main/java/org/exist/xquery/UntypedValueCheck.java
@@ -110,6 +110,7 @@ public Sequence eval(Sequence contextSequence, Item contextItem) throws XPathExc
 
     private Item convert(Item item) throws XPathException {
         if (atomize || item.getType() == Type.UNTYPED_ATOMIC || Type.hasMember(Type.NUMERIC, requiredType) && Type.subTypeOfUnion(item.getType(), Type.NUMERIC)) {
+//        if (atomize || item.getType() == Type.UNTYPED_ATOMIC || /*Type.hasMember(Type.NUMERIC, requiredType) &&*/ Type.subTypeOfUnion(item.getType(), Type.NUMERIC)) {
             try {
                 if (Type.subTypeOf(item.getType(), requiredType)) {
                     return item;
@@ -130,6 +131,7 @@ private Item convert(Item item) throws XPathException {
                 throw new XPathException(expression, e.getErrorCode(), error.toString());
             }
         }
+        // TODO(AR) need to consider the cases where the convert is doing nothing... what is its purpose from OpNumeric then?
         return item;
     }