Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20955] Prepare for 2.10.4 release #780

Merged
merged 5 commits into from
May 22, 2024
Merged

[20955] Prepare for 2.10.4 release #780

merged 5 commits into from
May 22, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented May 22, 2024 •
edited by Mario-DL
Loading

Description

Bump version and release notes for 2.10.4.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany MiguelCompany added this to the v2.10.4 - Frozen milestone May 22, 2024
@MiguelCompany
Copy link
Member Author

@richiprosima Please test docs

Mario-DL
Mario-DL reviewed May 22, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI, just waiting for eProsima/Fast-DDS/4826 in case we would want to include it

@MiguelCompany
Refs #20995. Apply suggestion.
1a2fc80 
Signed-off-by: Miguel Company <[email protected]>
Mario-DL
Mario-DL previously approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Refs #20995. Spell check.
35c5726 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test docs

@MiguelCompany MiguelCompany merged commit 6c76171 into 2.10.x May 22, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the release/2.10.4 branch May 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.4 - Frozen
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL