Reraise exceptions when debugging

evap/evaluation/models.py

@@ -28,6 +28,7 @@
 from django.utils.safestring import SafeData
 from django.utils.timezone import now
 from django.utils.translation import gettext_lazy as _
+from django.utils.translation import gettext_noop
 from django_fsm import FSMIntegerField, transition
 from django_fsm.signals import post_transition
 
@@ -958,6 +959,8 @@
                             evaluation_results_evaluations.append(evaluation)
                     evaluation.save()
             except Exception:  # noqa: PERF203
+                if settings.DEBUG:
+                    raise
                 logger.exception(
                     'An error occured when updating the state of evaluation "%s" (id %d).', evaluation, evaluation.id
                 )
@@ -2059,17 +2062,16 @@
 
     def send_to_user(self, user, subject_params, body_params, use_cc, additional_cc_users=(), request=None):
         if not user.email:
-            warning_message = (
-                f"{user.full_name_with_additional_info} has no email address defined. Could not send email."
-            )
+            message = gettext_noop("{} has no email address defined. Could not send email.")
+            log_message = message.format(user.full_name_with_additional_info)
             # If this method is triggered by a cronjob changing evaluation states, the request is None.
             # In this case warnings should be sent to the admins via email (configured in the settings for logger.error).
             # If a request exists, the page is displayed in the browser and the message can be shown on the page (messages.warning).
             if request is not None:
-                logger.warning(warning_message)
-                messages.warning(request, _(warning_message))
+                logger.warning(log_message)
+                messages.warning(request, _(message).format(user.full_name_with_additional_info))
             else:
-                logger.error(warning_message)
+                logger.error(log_message)
             return
 
         cc_users = set(additional_cc_users)
@@ -2109,6 +2111,8 @@
             if send_separate_login_url:
                 self.send_login_url_to_user(user)
         except Exception:
+            if settings.DEBUG:
+                raise
             logger.exception(
                 'An exception occurred when sending the following email to user "%s":\n%s\n',
                 user.full_name_with_additional_info,

evap/staff/tools.py

@@ -100,7 +100,7 @@ def find_matching_internal_user_for_email(request, email):
     return matching_users[0]
 
 
-def bulk_update_users(request, user_file_content, test_run):  # noqa: PLR0912
+def bulk_update_users(request, user_file_content, test_run):
     # pylint: disable=too-many-branches,too-many-locals
     # user_file must have one user per line in the format "{username},{email}"
     imported_emails = {clean_email(line.decode().split(",")[1]) for line in user_file_content.splitlines()}

pyproject.toml

@@ -37,7 +37,8 @@ ignore = [
     "COM812",                # incompatible with formatter
     "N802",                  # not as mighty as pylint's invalid-name https://github.com/astral-sh/ruff/issues/7660
     "PLR0913",               # we can't determine a good limit for arguments. reviews should spot bad cases of this.
-    "PLR2004", "PLW2901"
+    "PLR2004", "PLW2901",
+    "PLR0912",             # sevaral ruff bugs: https://www.github.com/astral-sh/ruff/issues/11313, https://www.github.com/astral-sh/ruff/issues/11205
 ]
 
 ignore-init-module-imports = true