Reraise exceptions when debugging #2167
Conversation
evap/evaluation/models.py
Outdated
| else: | ||
| logger.error(warning_message) | ||
| level = logging.WARNING | ||
| messages.warning(request, _(message)) |
There was a problem hiding this comment.
Does _(message) even work with the user data already formatted into message? Don't we usually do _("look at this data: {}").format(the_data)?
There was a problem hiding this comment.
reverted the 'simplification' and fixed the issue. Only did it in the first place to keep under ruff's too-many-branches. This is now only covered with pylint
There was a problem hiding this comment.
Do you know why ruff raised a pylint-based lint while pylint itself did not raise it? If the two check the same, we should probably prefer ruff for speed, right? (not a blocker for this PR)
There was a problem hiding this comment.
There was disagreement between pylint and ruff about how many branches there really are in the function. I think ruff counted one more than pylint, so the pylint check doesn't trigger while the ruff check does. Don't know if it's a ruff bug or if ruff thinks it's a pylint bug.
In general, I'd agree with @niklasmohrin to go with ruff for speed.
There was a problem hiding this comment.
Okay, maybe lets add this as a comment so we can revisit this later
There was a problem hiding this comment.
Ok, I will then enable ruff only and increase the limit by 1 taking the except-counting into account
There was a problem hiding this comment.
Ah well no. ruff has a bug there. It does not count branches inside with statements... astral-sh/ruff#11313
Kakadus
force-pushed
the
reraise-exceptions-when-debugging
branch
from
4971beb
to
d934ff7
Compare
This was raised during debugging #2136, concerning
update_evaluations. There, errors due to typeguard were silenced in the tests because of the raw except clause leading to weird test failures.This adds checks to reraise the exceptions when debugging.