Privacy Pro Free Trials Core Implementation (BSK Bump Only, No macOS Impacts) #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
changed the title
aataraxiaa
changed the title
miasma13
approved these changes
Jan 10, 2025
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 10, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/0/1208767141940868/f iOS PR: [Privacy Pro Free Trials Core Implementation](duckduckgo/iOS#3760) macOS PR: [Privacy Pro Free Trials Core Implementation (BSK Bump Only, No macOS Impacts)](duckduckgo/macos-browser#3693) What kind of version bump will this require?: **Minor** Tech Design URL: https://app.asana.com/0/1206488453854252/1208916720468103/f **Description**: This PR adds additional changes to support Privacy Pro Free Trials on iOS
aataraxiaa
force-pushed
the
pete/pp-free-trials-core-implementation
branch
from
23a937d to
c3629ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208767141940868/f
Description: BSK release only impacts iOS.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation